Hey look, I got ::bcmp working, I think... gist.github.com/danmcd/9945ae95e4a3db60c87a53fe86c88f02

Nice! I enjoy writing dcmds.

What does it print in a pipe context, the addr+offset?

test_string_1::bcmp test_string_2 -n a | /s

danmcd: and thank you for documenting the flags!!

(i've fixed several dcmds that didn't and just assumed you knew what they did)

@andyf ==> probably '<offset>/s' which doesn't help.

There's a WIP gerrit attached to the bug id now.

Well it would require an ::eval - I think it's useful to document the pipe behaviour whichever one you choose.

@jbk YW. Least I can do.

In the spirit of "keep it simple, no bikeshedding" I think people should prep for using ::eval, I guess.

Yep, I don't want to stop it being simple. It's trivial to implement either way (you can choose to print something different if (flags & DCMD_PIPE_OUT)) -- I would just like to see it in the help so we know.

I'm happy to take a review pass whenever you like - promise not to focus on the colour too much.

Also I'm willing to wiggle on pointer vs. offset for the output, but I'll allow that explicitly on Gerrit when I'm happy with it going from WIP to review-me-please.

Advice on how `addr2` can be parsed as either a name OR an actual address?

Ah, is it always MDB_TYPE_STRING ?

::dis and ::findbuf have examples, neither of them pretty..

er, ::findsym even

Yeah, look at dis_str2addr()

Thank you @andyf. Need to push it to gerrit again.

fenix illumos#17506

FEATURE 17506: Create ::bcmp dcmd (In Progress)

↳ illumos.org/issues/17506 | code.illumos.org/c/illumos-gate/+/4326