pmooney: do you know of real names for `PCIE_EXT_CAP_SRIOV_TOTAL_VFS` (0xe), or `PCIE_SRIOV_PAGE_SIZE_MULTIPLIER` (4096)? (I'm fixing #16789) (fenix?)

BUG 16789: qlc(4D) contains incorrect copies of much of the DDI (In Progress)

↳ illumos.org/issues/16789

and those are the two PCI_*/PCIE_* names I don't know the real name of

also, dear core folks. is the QLogic stuff "contrib" and I should be minimal here?

or is it never going to see a merge again in our wildest dreams, and I should update the code to use the real names

richlowe: uh, I do not

sorry

Regarding future merges, my inclination would be for you to make the changes you want.

But perhaps the other core folks have other opinions

richlowe: We don't have constants for the PCIe SRIOV cap structure offsets.

It does not seem likely that we will see a flurry of activity relating to fibre channel

rmustacc: ok, I will leave those here for now, short of knowing something better.

I'll look at how things go updating the source, rather than the values. I want to not disturb the output text

Yeah, I think the pair there right now we just kind of have to leave absent adding things to sys/pcie.h.