21:06:21 <richlowe> pmooney: do you know of real names for `PCIE_EXT_CAP_SRIOV_TOTAL_VFS` (0xe), or `PCIE_SRIOV_PAGE_SIZE_MULTIPLIER` (4096)?  (I'm fixing #16789) (fenix?)
21:06:22 <fenix> BUG 16789: qlc(4D) contains incorrect copies of much of the DDI (In Progress)
21:06:22 <fenix> ↳ https://www.illumos.org/issues/16789
21:06:44 <richlowe> and those are the two PCI_*/PCIE_* names I don't know the real name of
21:13:34 <richlowe> also, dear core folks.  is the QLogic stuff "contrib" and I should be minimal here? 
21:13:45 <richlowe> or is it never going to see a merge again in our wildest dreams, and I should update the code to use the real names
21:24:06 <pmooney> richlowe: uh, I do not
21:24:10 <pmooney> sorry
21:26:43 <pmooney> Regarding future merges, my inclination would be for you to make the changes you want.
21:27:03 <pmooney> But perhaps the other core folks have other opinions
21:27:05 * pmooney shrugs
21:27:30 <rmustacc> richlowe: We don't have constants for the PCIe SRIOV cap structure offsets.
21:28:14 <pmooney> It does not seem likely that we will see a flurry of activity relating to fibre channel
21:31:54 <richlowe> rmustacc: ok, I will leave those here for now, short of knowing something better.
21:32:15 <richlowe> I'll look at how things go updating the source, rather than the values.  I want to not disturb the output text
21:33:51 <rmustacc> Yeah, I think the pair there right now we just kind of have to leave absent adding things to sys/pcie.h.