are the makefiles and typical variables i'd see in illumos documented anywhere?

i think i was just looking at the same thing as jmc in code.illumos.org/c/illumos-gate/+/3…0a7c67f36ab9e4d5509a96f6bfd46da2282 but i had the much more rudimentary question "what does SMOFF mean here"

→ CODE REVIEW 3862: 16963 i86pc/unix: potential null dereference 'ht'. (NEW) | illumos.org/issues/16963

i've gotten to, controls which passes defined in smatch are off in building the object, somehow by adjusting CERRWARN maybe, which is consumed somewhere else

which is at least a mushy understanding of the words here, but feels like i've maybe missed something along the way

if this is also just me not having looked at enough C projects and makefiles, that's also quite fair :)

I don't think it's documented anywhere

You found "CERRWARN += $(SMOFF:%=-_smatch=--disable=%)" by the sound of it, which converts each <word> in SMOFF to -_smatch=--disable=<word>

Those are passed as parameters to "cw", the compiler wrapper, and the -_smatch means that this is a parameter for the compiler of flavour "smatch"

indeed, and the various <word>.c in smatch that looks like we parse gcc warnings for whichever purposes

which ends up with smatch being invoked with --disable=<word> --disable=<word> etc.

ah that was one i wasn't sure about, if cw is invoked before or after smatch

smatch is just defined as one of the shadow compilers, and cw takes care of running the primary and shadow compilers with the right options.

The dev-guide has a number of bits in the specific Makefile examples: illumos.org/books/dev.

uts/README has a bit there, but needs some improvements.

oh of course

That said, most of the dev-guide work I did wasn't refreshed post-SMATCH.

And in general, this can definitely be improved.

illumos.org/books/dev/anatomy.html is probably the page that has the most.

yeah, that's informative

either way the dev guide seems like the right place to look for and add more info. just hadn't looked there for a minute

If there's specific content, feel free to file bugs against it. Or if you have suggestions, even better.

yup, i'll do that

Thanks.

New to the illumos world and learning all the awesome possibilities these distros have to offer! Just installed OmniOs and learning the ins and outs. Nice to meet you all :D

welcome:)

Thank you thank you :D Excited to go down the rabbit hole

eek that's long

sorry

anyone coming? I should be there, it's across town

rmustacc, iximeow: If we're pointing people at uts/README, do you perhaps want to read mine and see if you'd find it better?

(I missed a lot of context)

but I'm eager for new victims to pass judgement on code.illumos.org/c/illumos-gate/+/3479 and friends

→ CODE REVIEW 3479: Introduce Makefile.kmod (NEW)

by "new victims", I especially mean people who would need the documentation we don't otherwise have

Yeah, I was thinking more so of your improved version actually.

was going to say "I don't see a change to uts/README in there" and then I noticed the "SHOW 200 MORE / SHOW ALL 587 FILES" at the bottom of the file list

richlowe: ooooh, yes, that seems quite relevant and informative

i'll take a closer look later

[illumos-gate] 16995 remove sun4v ldom static direct i/o (sdio) hooks -- Richard Lowe <richlowe⊙rn>