00:28:29 are the makefiles and typical variables i'd see in illumos documented anywhere? 00:29:03 i think i was just looking at the same thing as jmc in https://code.illumos.org/c/illumos-gate/+/3862/2#message-05ff40a7c67f36ab9e4d5509a96f6bfd46da2282 but i had the much more rudimentary question "what does SMOFF mean here" 00:29:04 → CODE REVIEW 3862: 16963 i86pc/unix: potential null dereference 'ht'. (NEW) | https://www.illumos.org/issues/16963 00:29:40 i've gotten to, controls which passes defined in smatch are off in building the object, somehow by adjusting CERRWARN maybe, which is consumed somewhere else 00:30:33 which is at least a mushy understanding of the words here, but feels like i've maybe missed something along the way 00:31:31 if this is also just me not having looked at enough C projects and makefiles, that's also quite fair :) 00:34:30 I don't think it's documented anywhere 00:35:03 You found "CERRWARN += $(SMOFF:%=-_smatch=--disable=%)" by the sound of it, which converts each in SMOFF to -_smatch=--disable= 00:35:35 Those are passed as parameters to "cw", the compiler wrapper, and the -_smatch means that this is a parameter for the compiler of flavour "smatch" 00:35:49 indeed, and the various .c in smatch that looks like we parse gcc warnings for whichever purposes 00:35:51 which ends up with smatch being invoked with --disable= --disable= etc. 00:36:01 ah that was one i wasn't sure about, if cw is invoked before or after smatch 00:36:45 smatch is just defined as one of the shadow compilers, and cw takes care of running the primary and shadow compilers with the right options. 00:44:26 The dev-guide has a number of bits in the specific Makefile examples: https://illumos.org/books/dev/. 00:44:45 uts/README has a bit there, but needs some improvements. 00:44:50 oh of course 00:45:30 That said, most of the dev-guide work I did wasn't refreshed post-SMATCH. 00:45:41 And in general, this can definitely be improved. 00:46:12 https://illumos.org/books/dev/anatomy.html is probably the page that has the most. 00:47:36 yeah, that's informative 00:48:29 either way the dev guide seems like the right place to look for and add more info. just hadn't looked there for a minute 00:49:49 If there's specific content, feel free to file bugs against it. Or if you have suggestions, even better. 00:53:56 yup, i'll do that 00:54:09 Thanks. 12:25:55 New to the illumos world and learning all the awesome possibilities these distros have to offer! Just installed OmniOs and learning the ins and outs. Nice to meet you all :D 12:31:23 welcome:) 12:40:52 Thank you thank you :D Excited to go down the rabbit hole 18:48:36 https://events.linuxfoundation.org/open-source-summit-north-america/?utm_campaign=5123493-Open%20Source%20Summit%20North%20America%202025&utm_medium=email&_hsenc=p2ANqtz-8r9soOjo95L-gP-ZYwn20kMJIyUggLYbWaYvstfCwCsY6tGpZA-d327SkCs6ATEqvfgM5UqQfmZux51i5l1Ltjvee7AQ&_hsmi=343433386&utm_content=343433386&utm_source=hs_email 18:48:46 eek that's long 18:48:49 sorry 18:49:16 anyone coming? I should be there, it's across town 19:14:24 rmustacc, iximeow: If we're pointing people at uts/README, do you perhaps want to read mine and see if you'd find it better? 19:14:36 (I missed a lot of context) 19:15:13 but I'm eager for new victims to pass judgement on https://code.illumos.org/c/illumos-gate/+/3479 and friends 19:15:14 → CODE REVIEW 3479: Introduce Makefile.kmod (NEW) 19:15:30 by "new victims", I especially mean people who would need the documentation we don't otherwise have 19:52:51 Yeah, I was thinking more so of your improved version actually. 19:54:42 was going to say "I don't see a change to uts/README in there" and then I noticed the "SHOW 200 MORE / SHOW ALL 587 FILES" at the bottom of the file list 20:16:46 richlowe: ooooh, yes, that seems quite relevant and informative 20:16:53 i'll take a closer look later 22:11:38 [illumos-gate] 16995 remove sun4v ldom static direct i/o (sdio) hooks -- Richard Lowe