-
ptribble
-
fenix
→
BUG 16523: int8_t should explicitly be signed char (New)
-
ptribble
Now, I haven't hit any problems with applications by making int8_t be explicitly 'signed char', and it does solve a bunch of issues
-
ptribble
It does, however, rather spectacularly break the gate build
-
jperkin
yeh I've been running with a variant of that for over a year
-
ptribble
Haven't had time to look at them all yet, but I get a bunch of signedness errors that seem off
-
ptribble
error: pointer targets in passing argument 2 of 'strncpy' differ in signedness [-Werror=pointer-sign]
-
ptribble
Where it's storing a string in an int8_t[] and pssing it to something that expects a char
-
ptribble
Was using int8_t to store characters a pattern at some point? My guess would be that using char where char is actually meant would fix most of these.
-
andyf
richlowe will have had a load of experience in the arm port too, from the other side where char is unsigned.
-
andyf
So it's likely some of the fixes are already in that branch
-
ptribble
Yeah, on quick inspection it looks like they're covered. Upstreaming would be nice, although I'm not entirely sure of the precise attribution for any given hunk in the diffs.
-
ptribble
I think what I may do is pick what's necessary to build the next Tribblix release, which will have the modified header, and use that as a testbed
-
richlowe
as andy said, I fixed a bunch of int8-as-char stuff
-
richlowe
an awful lot in wifi drivers as I recall
-
richlowe
it smelled like someone got told "used fixed size integers" and not why, and overreacted.
-
richlowe
ptribble: attribution is `git blame`, if it blames to the first commit that credits everyone, credit everyone
-
richlowe
and as the readme says, talk to me before upstreaming anything.
-
richlowe
(I should update that to say "me, or anyone equivalent to me")
-
alanc
So illumos-discuss is now a single person's stream of consciousness?
-
richlowe
you're the 2nd person to have mentioned that today
-
richlowe
danmcd: I dunno if this is in your ballpark, since I don't think it's _inappropriate_
-
richlowe
or at least, not with the connotations that word has
-
andyf
I don't actually know how to classify it at all.
-
alanc
the bits about Windows/Crowdstrike/etc seem off-topic, not offensive
-
rzezeski
It feels like spamming a list. I see no apparent direction or purpose to these series of messages.
-
alanc
It might feel different if anyone else was responding to him, but it seems to be him just responding to himself over and over and over
-
jperkin
if it's the same person that was spamming a month or so ago, that was the reason I unsubbed
-
alanc
From
illumos.topicbox.com/groups/discuss he looks like he's been most of the list traffic since May or so
-
richlowe
then yeah, danmcd's the person you want I think
-
andyf
I'm not sure he's around just now
-
richlowe
yeah, I'm not either, that's just the extent to which I remember things
-
alanc
it's not yet at a level where it's urgent something be done, just getting noticable
-
jclulow
I'm actually dealing with it
-
jclulow
I apologise for the noise.
-
jclulow
It's definitely off-topic.
-
richlowe
jclulow: sorry, was hoping to save you
-
jclulow
It's all good
-
xaero
anyone here using illumos on the new(ish) intel cpus with big.LITTLE?