-
sjorge
Oh the s10 zones were upstream gate, I though that got removed there ages ago with the sparc paltform... guess not
-
jbk
hrm... sata.c is approaching sd.c levels of ridiculous size... I wonder how objectionable it'd be to split the scsa bits and the sxlt (translation) bits to keep the sizes from getting too ridiculous
-
jbk
(as part of support for more translation of stuff.. we don't implement the entire scsi/sata translation spec)
-
jbk
github.com/illumos/illumos-gate/blo…ommon/io/sata/impl/sata.c#L852-L857 -- is it me, or wouldn't it just be simpler to snprintf(taskq_name, sizeof (taskq_name), "%s-%d", ...) ?
-
jclulow
21k lines is really too many lol
-
» danmcd can't remember how big the OG $INET/ip.c was...
-
jclulow
jbk: yes that taskq_name business is obscene
-
jbk
i mean i think sd.c probably has the record
-
jbk
(32k)
-
danmcd
Hmmm... lemme look...
-
jbk
i got pulled away on a different issue, but I was going to add some additional log page support to our satl is why I was asking
-
danmcd
Rolling back to the first commit of illumos-gate, ip.c was 25k lines. It's now 15k post-datapath-refactoring.
-
alanc
wc -l on the on10 usr/src/uts/common/inet/ip/ip.c gives 31387
-
alanc
that's after all the update releases though, so may have some backports that happened after the nevada gate was split off
-
danmcd
Thank you alanc; I thought it was even bigger before.
-
jbk
if you do a ping w/ a non-default (larger) data size, is there a limit on the size of pings we'll reply to?
-
jbk
just to test some stuff, i'm doing a ping IP 8000 (mtu is set to 9000)... snoop shows it received, but dtrace suggests the driver is not getting a reply packet to send
-
jbk
if i lower it to 4000, then i do
-
danmcd
jbk: ---> If MTU == 9000 and you send an 8000 byte ping, you should get back a 8000 byte ping unless you hit a router that has MTU == 1500. pathMTU should kick in with subsequent pings.
-
danmcd
Is this an on-link peer?
-
danmcd
If so I wonder if on-link peer has MTU < 5000 ?
-
danmcd
(Or some other mismatch?)
-
danmcd
ANd there should be no limit.
-
danmcd
Yeah, I just sent 8k pings over a 9kMTU local link.
-
danmcd
(and got them back).
-
danmcd
For 9000 MTU, use "8972" as the argument for illumos ping(1) for size:
-
danmcd
`ping -svn DEST 8972 <count>`
-
jbk
ahh.. i think I've found the problem (kinda)..
-
rmustacc
You should set -D if you do this.
-
rmustacc
To ensure there's no fragmenting.