14:43:54 <sjorge> Oh the s10 zones were upstream gate, I though that got removed there ages ago with the sparc paltform... guess not
14:57:58 <jbk> hrm... sata.c is approaching sd.c levels of ridiculous size... I wonder how objectionable it'd be to split the scsa bits and the sxlt (translation) bits to keep the sizes from getting too ridiculous
14:58:34 <jbk> (as part of support for more translation of stuff.. we don't implement the entire scsi/sata translation spec)
15:40:18 <jbk> https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/io/sata/impl/sata.c#L852-L857 -- is it me, or wouldn't it just be simpler to snprintf(taskq_name, sizeof (taskq_name), "%s-%d", ...) ?
21:45:08 <jclulow> 21k lines is really too many lol
21:46:22 * danmcd can't remember how big the OG $INET/ip.c was...
21:46:59 <jclulow> jbk: yes that taskq_name business is obscene
21:48:22 <jbk> i mean i think sd.c probably has the record
21:52:40 <jbk> (32k)
21:53:21 <danmcd> Hmmm... lemme look...
21:53:33 <jbk> i got pulled away on a different issue, but I was going to add some additional log page support to our satl is why I was asking
21:56:05 <danmcd> Rolling back to the first commit of illumos-gate, ip.c was 25k lines.  It's now 15k post-datapath-refactoring.
22:05:33 <alanc> wc -l on the on10 usr/src/uts/common/inet/ip/ip.c gives 31387
22:06:54 <alanc> that's after all the update releases though, so may have some backports that happened after the nevada gate was split off
22:11:55 <danmcd> Thank you alanc; I thought it was even bigger before.
22:25:15 <jbk> if you do a ping w/ a non-default (larger) data size, is there a limit on the size of pings we'll reply to?
22:27:20 <jbk> just to test some stuff, i'm doing a ping IP 8000 (mtu is set to 9000)... snoop shows it received, but dtrace suggests the driver is not getting a reply packet to send
22:27:27 <jbk> if i lower it to 4000, then i do
22:34:05 <danmcd> jbk:  ---> If MTU == 9000 and you send an 8000 byte ping, you should get back a 8000 byte ping unless you hit a router that has MTU == 1500.  pathMTU should kick in with subsequent pings.
22:34:16 <danmcd> Is this an on-link peer?
22:34:28 <danmcd> If so I wonder if on-link peer has MTU < 5000 ?
22:34:34 <danmcd> (Or some other mismatch?)
22:34:50 <danmcd> ANd there should be no limit.
22:36:30 <danmcd> Yeah, I just sent 8k pings over a 9kMTU local link.
22:36:35 <danmcd> (and got them back).
22:38:46 <danmcd> For 9000 MTU, use "8972" as the argument for illumos ping(1) for size:
22:38:57 <danmcd> `ping -svn DEST 8972 <count>`
23:01:22 <jbk> ahh.. i think I've found the problem (kinda)..
23:12:53 <rmustacc> You should set -D if you do this.
23:12:59 <rmustacc> To ensure there's no fragmenting.