nice

hmm interesting... vmware's NVMe emulation says it supports dataset management, but if you issue a dataset mgmt command, it returns an invalid cmd error that causes a panic

(i.e. don't try to trim a VMware NVMe zpool :P)

Ouch, you should definitely open a bug for that if you haven't already.

oooofff

yeah, we probably should perhaps be a bit smarter about handling invalid commands

though the NVMe spec refers to some parameter limits that (at least in current versions) don't appear to actually be documented (at least trying to search through the PDFs)

as I was wondering if maybe our 'can we do TRIM on NVMe' needs additional checks beyond the 'support dataset management' bit

jbk for a 20h/00h INVALID COMMAND OPERATION CODE on vioscsi I need to check actually sd driver or where to find out which cmd was sent ?

probably

i'm extremely sleep deprived today, so not exactly thinking straight

jbk no problem, seems is really an issue with the hypervisor that they are using in oci, I just tested openbsd 7.2 and it crashes when loading vioscsi, it used to work

Does someone have a system with mpt_sas sitting around that they could help test something on?

rmustacc: i have one

Woodstock: Are you in a place that you could run something on it and try a disk pull?

rmustacc: yes, that should work

I'll e-mail you details?

sure

I also have two boxes using mpt_sas I believe if you need additional data points

Yeah, that will.