[illumos-gate] 15399 snoop: when tcp payload size is 0, there is no next protocol -- Toomas Soome <tsoome⊙mc>

[illumos-gate] 15384 libefi: add efi_devpath_next_instance() -- Toomas Soome <tsoome⊙mc>

[illumos-gate] 15403 statd: Fix the wrong use of logical AND in place of bitwise AND operator. -- Suresh Jayaraman <suresh.jayaraman⊙tc>

@tsoome_

yes?

NVM.

New for-loop rules caught a smartos-only piece of zoneadmd.c:

Thought I had Real Problems, but it was just my own.

yes, previously you had to have those or cstyle did complain.

Did the style rules change? I thought that they were unchangeable given that we are using "Bill Joy Normal Form".

Someone in #c was telling me that we should not require parentheses for sizeof or return. I replied that it was not up to me.

no, just fixed previously broken for loop check

btw, fbsd insists parentheses for return, but not for sizeof.

small but annoying difference

tsoome_: Where is that fix? We might need it in OpenZFS to ensure that we are using the same style rules.

*our* ZFS needed no changes, AFAICT, so OpenZFS is *likely* in the clear. See my illumos-joyent commit above for an example.

ryao 14596

tsoome_: Thanks.

Ultimately, illumos style is not set in stone and is something that we as a project will evolve. For example, alignof didn't exist, but we need to update tracking for it in tools.

I am fine with using the same style that we have always used unless there is a new reason to change/amend it.

alignof would be one such reason.

[illumos-gate] 15419 comments in amdzen.c could be edited -- Dan Cross <cross⊙oc>

[illumos-gate] 15292 sgs: set but not used variable -- Toomas Soome <tsoome⊙mc>