15:44:52 <gitomat> [illumos-gate] 15399 snoop: when tcp payload size is 0, there is no next protocol -- Toomas Soome <tsoome⊙mc>
17:29:41 <gitomat> [illumos-gate] 15384 libefi: add efi_devpath_next_instance() -- Toomas Soome <tsoome⊙mc>
17:41:09 <gitomat> [illumos-gate] 15403 statd: Fix the wrong use of logical AND in place of bitwise AND operator. -- Suresh Jayaraman <suresh.jayaraman⊙tc>
18:08:39 <danmcd> @tsoome_ 
18:08:47 <tsoome_> yes?
18:25:27 <danmcd> NVM.
18:25:41 <danmcd> New for-loop rules caught a smartos-only piece of zoneadmd.c:
18:25:56 <danmcd> https://github.com/TritonDataCenter/illumos-joyent/commit/3a61b470f77f33aeb7ba18907c25e1f5d47e1497
18:26:07 <danmcd> Thought I had Real Problems, but it was just my own.
18:43:10 <tsoome_> yes, previously you had to have those or cstyle did complain.
18:45:49 <ryao> Did the style rules change? I thought that they were unchangeable given that we are using "Bill Joy Normal Form".
18:46:19 <ryao> Someone in #c was telling me that we should not require parentheses for sizeof or return. I replied that it was not up to me.
18:49:35 <tsoome_> no, just fixed previously broken for loop check
18:50:37 <tsoome_> btw, fbsd insists parentheses for return, but not for sizeof.
18:50:47 <tsoome_> small but annoying difference
18:51:40 <ryao> tsoome_: Where is that fix? We might need it in OpenZFS to ensure that we are using the same style rules.
18:52:53 <danmcd> *our* ZFS needed no changes, AFAICT, so OpenZFS is *likely* in the clear.  See my illumos-joyent commit above for an example.
18:54:01 <tsoome_> ryao 14596
18:57:54 <ryao> tsoome_: Thanks.
18:58:35 <rmustacc> Ultimately, illumos style is not set in stone and is something that we as a project will evolve. For example, alignof didn't exist, but we need to update tracking for it in tools.
19:08:04 <ryao> I am fine with using the same style that we have always used unless there is a new reason to change/amend it.
19:08:18 <ryao> alignof would be one such reason.
20:06:41 <gitomat> [illumos-gate] 15419 comments in amdzen.c could be edited -- Dan Cross <cross⊙oc>
20:21:05 <gitomat> [illumos-gate] 15292 sgs: set but not used variable -- Toomas Soome <tsoome⊙mc>