g'morning:)

.oO already found real bug with warning suppression lifted...

[illumos-gate] 15116 find_elf does not find non-executable .so files -- Andy Fiddaman <illumos⊙fn>

tsoome - nice :)

error: '&' within '^'

!(ntohl(*(uint32_t *)buff) & 2^31)

another one

oh dear wishful wysiwig C

I'm not really even sure what is the idea there

looks to me that someone thought that 2^31 means two to the power of 31

meaning 1 << 31

yep

using xor does not really make much sense

tsoome: gcc.gnu.org/bugzilla/show_bug.cgi?id=90885 :P

That looks handy

yeah

heh:)

anyhow, this is the function and I have no idea why it has this check. src.illumos.org/source/xref/illumos….c?r=48bbca81&mo=44220&fi=1679#1679

Me neither..

There is this..

if I had to guess.. assuming buff is a complete message, and assuming the first 4 bytes are a network byte order length of the message

and assuming it's treating it as a signed value...

(which is a lot of assumptions...)

oh, I see

if (!LAST_FRAG()) ?

yea, that would be helpful for poor human reading this code:D

44:#define MAX_XID (2^16)

at least there aren't too many in the gate

yeah.. that would make the intent clearer