06:09:14 <tsoome> g'morning:)
06:10:12 <tsoome> .oO already found real bug with warning suppression lifted...
11:05:23 <gitomat> [illumos-gate] 15116 find_elf does not find non-executable .so files -- Andy Fiddaman <illumos⊙fn>
11:20:28 <andyf> tsoome - nice :)
11:23:37 <tsoome> error: '&' within '^'
11:23:52 <tsoome> !(ntohl(*(uint32_t *)buff) & 2^31)
11:24:04 <tsoome> another one
11:27:15 <paulf> oh dear wishful wysiwig C
11:28:21 <tsoome> I'm not really even sure what is the idea there
11:29:12 <paulf> looks to me that someone thought that 2^31 means two to the power of 31
11:29:33 <paulf> meaning 1 << 31
11:29:37 <tsoome> yep
11:30:01 <tsoome> using xor does not really make much sense
12:38:15 <jlevon> tsoome: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90885 :P
12:42:40 <andyf> That looks handy
13:07:08 <jbk> yeah
14:33:41 <tsoome> heh:)
14:35:47 <tsoome> anyhow, this is the function and I have no idea why it has this check. https://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libnsl/rpc/clnt_vc.c?r=48bbca81&mo=44220&fi=1679#1679
14:48:10 <andyf> Me neither..
14:49:58 <andyf> There is this..
14:50:23 <jbk> if I had to guess.. assuming buff is a complete message, and assuming the first 4 bytes are a network byte order length of the message
14:50:32 <andyf> https://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libnsl/rpc/xdr_rec.c?r=61961e0f#71
14:50:53 <jbk> and assuming it's treating it as a signed value...
14:51:06 <jbk> (which is a lot of assumptions...)
14:52:50 <tsoome> oh, I see
14:55:52 <andyf> if (!LAST_FRAG()) ?
14:57:15 <tsoome> yea, that would be helpful for poor human reading this code:D
14:59:30 <andyf> 44:#define      MAX_XID         (2^16)
14:59:35 <andyf> at least there aren't too many in the gate
15:01:38 <jbk> yeah.. that would make the intent clearer