[illumos-gate] 14944 xhci silently drops ugen transfers sometimes but not always -- Joshua M. Clulow <josh⊙so>

Is there something for gerrit that will automatically update reviewed by? Or do I need to manually edit the commit message and push it?

you need to manually do it

I think a handful of us have scripts to give you the list from the gerrit API

mine is bad, but I think andyf's isn't

OK. And I'm assuming this won't invalidate the reviews if I'm only modifying the commit message?

I can share what I've got if you like

bahamat: Yes as long as you don't also rebase at the same time

I just usually don't update the message in gerrit, I just do it for the RTI

It's fine to make it the advocate's problem.

core team member

but yes

:D

oh yeah, that too, though them being in the email helps.

Ok...and I pushed the wrong thing.

to where?

not master!

It doesn't appear so.

At least not on 14967.

I did HEAD:refs/for/master, and only afterward remembered that I'm supposed to push to this change ID or something

that's fine

gerrit is clever and updates because the change-id

that's totally fine -- it looks at the Change-Id: in there to figure out what to do with it

yeah

that's what the change-id is for

Exactly.

Oh, no the output from git push says it's the same cr number

it'll say like "updated: 1"

(and also "4. Update your change with new contents")

OK, that looks like I did it right.

if you can't push to master, it's almost foolproof

or rather to branches other than refs/for/...

Ok, RTI is away. I think I got it all.

And richlowe --> I'll push it for bahamat upon approval.

I'm trying to land my python thing you just approved, for marcel

so I haven't looked at anything beyond hitting the button in topicbox

SOrry, I shouldn't have picked on you per se. That should've been more generic.

Take your time on the python one. (I'm just glad today's merge trash-fire was all my fault.)

To be fair, I made exactly the same mistakes with the omnios merge...

and now s10 zones are broken in omnios bloody, which is also probably my fault

[illumos-gate] 14847 illumos should default to python 3.9 -- Richard Lowe <richlowe⊙rn>

danmcd - s10 brand has been broken for us since OS-4151 (fenix) - panic in DEBUG, memory leak otherwise

OS-4151: setbrand hooks should be sane during fork (Resolved)

↳ smartos.org/bugview/OS-4151

so it isn't new, and not AVX512 related, thankfully :)