jclulow: I have a fix for 14697, but gerrit tells me I don't have create permission.

I'm not sure if my permissions got screwed up somehow, or if I got culled at some point.

bahamat: what was the error? (and what ref were you trying to push?)

pmooney: remote: You need 'Create' rights to create new references.

Pushing this branch: bahamat/illumos-joyent 4696402

bahamat: I can push to gerrit on your behalf if you wish.

(though getting perms is the better long-term solution.)

It used to work.

Is it because you're now @mnx.io instead of @joyent.com ? That should've smoothly migrated...

If there was a policy change about who's allowed to push, I must have missed it.

gerrit has my mnx address in my profile.

Hmmph.

Pushing HEAD:refs/for/master ?

remote: error: branch refs/heads/i_14967:

For a new review, you need to use refs/for/master as far as I know

you're trying to push the branch name itself, instead of to the create-a-new-change-for-me ref

You did do "git push you⊙cio:/illumos-gate HEAD:refs/for/master" ?

yeah

Oh...ok.

HEAD assumes you have the branch in question checked out at the time

it'll also require a Change-id in the commit message for gerrit's tracking purposes

I always forget about that HEAD:refs/for/master

I think I ask about that every damn time :-/

alias gerrit='git push gerrit HEAD:refs/for/master' ;)

[illumos-gate] 14236 signed math leads getelfshdr astray -- Patrick Mooney <pmooney⊙pc>

*confetti*

one of the great advantages of using gerrit properly, will be not being allowed to push to master by mistake

which terrifies me

yeah, I'll appreciate that safety

wrapper scripts with lots of checks ftw

(but am grumpy about how it means Change-id garbage in the commit messages)

andyf: doesn't prevent me from accidentlly doing `push cr master` instead of `push cr HEAD:refs/for/master`

I'm also not wild about scripts that do automatic attribution, as some folks have gerrit-specific emails configured

I was not really suggesting scripts are better than automation there..

but I have hidden the refs/for/master thing in a git alias, so just `git pg` which means I never even remember it without looking

I'm a git weirdo who does a lot of stuff by hand

(like always fetch/merge instead of pull)

I'm a git weirdo who doesn't trust magic near illumos repos

and even then I've fucked it up at least twice

and then I borrowed jlevon's "push-to-gate" script which does the check things

Is there a plan to put gerrit in charge of landing things?

what do you mean by "plan"?

there's like, 8 people going "Gosh, I wish I had time for that"

is that a plan?

Haha

I was looking for a mailing list thread or IPD or something.

There is not a concrete plan

At some point we could just rip the band-aid off tbh

As someone who rarely integrates anything, I was more curious and surprised rather than feeling like I have an "Important Opinion" (TM)

I think I interpreted pmooney's "I'll appreciate that safety" as implying that there was a concrete plan.

I'll go back to being quiet now. :)

the safety is that when you do it, none of us can push to master anymore

except jclulow

and unfortunately probably me :(

richlowe: I have a pattern for a sudo mode

so you can have a switch to turn on/off for doing it

does anyone know off the top of my head if I mark something __unused then use it, can I get gcc to tell me?

I do not think so...

doh

heh, gcc.gnu.org/bugzilla/show_bug.cgi?id=51579, looks like no one was interested

[illumos-gate] 14867 panic in smb_request_alloc / smb_oplock_ind_break during shutdown -- Gordon Ross <gordon.ross⊙tc>