-
vgusev
tsoome: About
illumos.org/issues/18334 . How to catch this smatch errors? When I compileв illumos, I didn't see those errors.
-
fenix
→
BUG 18334: stmf_sbd: string too large for strcpy() (In Progress) |
code.illumos.org/c/illumos-gate/+/4949
-
tsoome
thats newer smatch.
-
vgusev
tsoome: So it needs to change Makefile before?
-
tsoome
I can't push it yet there are still bunch of errors it does discover:)
-
tsoome
no, not makefile, the smatch itself is updated...
-
tsoome
but it is not yet on gate.
-
tsoome
-
tsoome
18334 will receive a small addition soon, need to verify it and then will update gerrit.
-
vgusev
tsoome: Could you give more information how to enable smatch for smtf/stmf_sbd? I would also run it and check.
-
tsoome
it is enabled by default, but if you want to check with my current update, grab the
github.com/tsoome/illumos-gate/tree/smatch_update_labels and run make install in usr/src/tools/smatch, then you can switch to branch with your changes and run make manually
-
vgusev
tsoome: Sorry, I didn't get. You wrote "thats newer smatch". Does it mean that stmf is not checked by smatch?
-
tsoome
it is, but the smatch on gate is older than I have.
-
tsoome
so it does detect less problems...
-
rzezeski
tsoome: what version are you upgrading to?
-
rzezeski
wondering if it includes
error27/smatch 91b751f
-
fenix
→ GitHub commit 91b751f: flow: set prev_stream (committed)
-
rzezeski
because that might knock some time of the build, IIRC maybe 30s?
-
tsoome
I think, I have last commit as commit e9cc34fddeaf6e740cb761bf59d4615be6852652 Date: Wed Apr 22 12:30:33 2026 +0300 - from
github.com/error27/smatch.git. I havent had time to check latest for awhile.
-
tsoome
I have it + updates to smatch to track kmem_alloc and friends and almost all cleanups so far in
github.com/tsoome/illumos-gate/tree/smatch_update_labels - however, as usual, some of the cleanups can be improved... but also, this newer smatch has bug about detecting double free I havent been able to diagnose properly - so it is not something we want to push immediately even as it does pretty good job in other areas.
-
gitomat
[illumos-gate] 18314 vmc_space_unmap() iterates the held-pages list with the wrong object -- Andy Fiddaman <illumos⊙fn>
-
Warcop
Hi i'm looking to set up a demonstration of illumos or a variant for an internal team. My ask is what's the general familiarty bias for the most popular "distribution" of illumos.
-
pedja
if you want to 'get the gist' on most actively developed illumos distributions, take a look at 'Stephen's Machine Room' illumos playlist on yt
-
pedja
he covers OI, omnios, tribblix and some smartOS
-
Warcop
Copy that. Thanks.
-
Warcop
Some of those videos have some fantastic dates on them. Kind of threw me off for a second with that playlist.
-
pedja
yeah, they are old-ish, but the information is, for the most part, still relevant today, afaict
-
pedja
unfortunately, nor that much of a illumos content out there, which is a shame, imho
-
Warcop
I get that it's a niche, and I'm not just trying to jump to my own famliarity bias. I'll probably go back and listen to the Oxide and Friends podcast episode as well
-
nomad
jbk: Sorry to be such a pest. I'm getting a lot of pressure to get the new fileserver online and in service. Any projections on ICE driver availability?
-
gitomat
[illumos-gate] 18301 zfs panic "decompression failed" with gzip compression and low memory -- Matthew Ahrens <matt⊙mo>
-
jbk
nomad: i'm working on it... that's the best I can say...
-
jbk
this thing is so fucking overengineered, it could be working today, or it could be another two months of working through code
-
jbk
i'm sorry but you really should have chosen a different NIC
-
jbk
i'm working my ass off trying to get it working, but even that doesn't seem to be enough
-
jbk
(I actually hope it's the last NIC intel produces, because there's no way I'm writing a driver for the next one)
-
nomad
I wish we'd had a different NIC as well but the only alternative we were offered is one danmcd said to avoid so we went with this one. <sigh>
-
ENOMAD
IIRC the alternative was something that would never be supported. I think it was from broadcom but I could easily be misremembering.
-
danmcd
ENOMAD it was Broadcom.