-
jbk
oh how i wish the kernel's bzero() actually set up a stack frame
-
richlowe
it's a leaf right? what do you need the frame for?
-
richlowe
(I'm confused about this one, basically)
-
richlowe
gwr: do you still need reviews from me for my bugs? it's _so hot_ here rn my brain doesn't work
-
jbk
well more the lack of a frame pointer
-
jbk
so the calling function doesn't show up in the stack
-
jbk
while you can usually infer it from the offset (the instruction offset will be after the function that was called)
-
jbk
but then you have to crawl the stack to find the arguments passed to that invisible function
-
jbk
which is tedious
-
jbk
and for various reasons, I'm rather brain fried and exhausted today, so it's not a mental exercise I really want to attempt today
-
richlowe
are those reasons that it's a million fucking degrees there too?
-
richlowe
because I sympethesize from the surface of the sun
-
jbk
oh that's pretty much summer here..
-
jbk
no, I was up rather late fighting ESX's horrid NFS4 support
-
jbk
and then was woken up early this morning because people decided to set off fireworks (and down here you can get the 'big' fireworks)
-
jbk
a few days early
-
jbk
so I'm working off like 4-5 hours of sleep, so the focus needed isn't there today :)
-
nomad
Mayhap it is naptime.
-
gwr
We have New Hampshire only a couple miles from here, which some call "The South of the North". The let you have fireworks too.
-
nomad
Fireworks are illegal in Seattle. That didn't stop $idiotneighbor from setting off several loud explosions between 23:00 and midnightish last night.
-
jbk
I suppose it's at least refreshing they don't bother with the pretense... where I grew up, they could sell all sorts of stuff that was illegal to set off in the state, but they were fine with selling it as long as you signed a waiver you were taking them out of state *wink*wink*
-
jbk
(despite they not being legal in any state within a 4-5 hour drive)
-
nomad
We have plenty of tribes with different laws about fireworks so it's trivial to get them in .wa.us.
-
jbk
illinois troopers would often camp out on the state line this time of year just to bust people taking the fireworks into the state
-
gitomat
[illumos-gate] 5048 panic on re-adding an interface to an aggr after removing it -- Dan McDonald <danmcd⊙ei>
-
jbk
i mean it was fun since some family friends had moved out of town to the country and would have a big party for the 4th of july, and one of the people would usually drop a few hundred bucks on the big fireworks to set off...
-
jbk
and never got busted
-
jbk
and would do it on the 4th and not too late
-
andyf
jbk there is a proposal somewhere to teach `mdb` about some of these functions, rather than incur the cost of the frame setup.
-
andyf
illumos 17585 (fenix)
-
fenix
FEATURE 17585: MDB should look past mutex_enter() and find the real stack frame (New)
-
fenix
-
jbk
oh that would be sooooo nice
-
jbk
there was that code that someone at joyent wrote (but not sure anyone remembers who :P) that'll walk the dwarf/amd64 exception data... I had been trying to carefully fold it into libproc (as an alternative -- not to replace -- walking the frame pointers.. mostly for the lx stuff)
-
jbk
but never got around to finishing it (the code was just a proof of concept program to decode the data)
-
jbk
though I don't recall offhand if we strip that off of kernel modules or not
-
richlowe
rmustacc has had a variety of dwarven prototypes
-
richlowe
we strip all dwarf unless you do a build with source debugging
-
jbk
(I feel like a LOTR refrence would be appropriate now, but can't think of one :P)
-
richlowe
when you do such a build, kernel stuff has dwarf too and it is 80% usable
-
richlowe
(20% unusable because gdb insists on being told where in memory stuff got placed, and we don't have a strictly great answer for bss)
-
richlowe
have any of you used `git cherry` (that creates a list of things you might `cherry-pick`) and been convinced that the patch-id equivalence etc, etc, actually worked?
-
richlowe
my list of "cherries" includes everything I have just already picked
-
richlowe
suspicious, no?
-
Smithx10
jbk: I'm having a strange issue with i40e and toolong_error kstat, anyway to dtrace to see what size we are rx'ing that bumps the counter?
-
richlowe
(a kstat dtrace provider would be cool...)
-
jbk
is that the actual kstat name?
-
jbk
(it might be the aforementioned lack of sleep, but i'm not seeing a kstat with a name like that in the i40e driver)
-
Smithx10
-
jbk
oooh
-
rmustacc
Those are coming from the hardware.
-
rzezeski
I was just typing that
-
rzezeski
you wont' see it, because well, the NIC rejected it
-
richlowe
hardware and then softmac for the stat to become a stat
-
richlowe
I guess?
-
Smithx10
errrrr, so I'll need to get it from switchport I guess?
-
rmustacc
This register counts the number of received frames that are longer than maximum size as defined by the Set MAC config command
-
rzezeski
Smithx10: just tell people to shorten their packets. brevity is the soul of wit, or something
-
rmustacc
Receive Oversize Count - GLPRT_ROC in the datasheet.
-
jbk
'you using those sized packets? in this economy?'
-
Smithx10
jbk hahaha yes
-
Smithx10
Very strange.... When we tx 9k and rx 9k from another CN that are in the same vlan and never go over the gateway we are good
-
Smithx10
when the gateway is in the flow we get the err toolong and its getting dumped
-
Smithx10
oddly chelsio is working without issues
-
rzezeski
Oh, this is tickling an old memory of mine when I was working on a maxbw fix. I believe this could do with our setting of m_margin. Basically all our drivers set it to VLAN_TAGSZ, but I believe that's wrong. The only driver that doesn't set it to VLAN_TAGSZ...cxgbe. It sets it to 22. I would have to look more closely to give coherent story here, but basically this could be related to m_max_sdu/m_margin/etc.
-
rzezeski
Though I wonder if that chelsio is running an older PI, because I noticed Patrick changed cxgbe to set m_margin to VLAN_TAGSZ while he was doing his cleanup
-
rzezeski
There's some discussion in dlpi(7P) about the margin value.
-
rzezeski
Basically I ran into this while doing the maxbw work and it seemed like a huge quagmire and then I got pulled into seomthing else
-
richlowe
best way out of a quagmire tbf
-
richlowe
rip artax
-
rzezeski
richlowe: I'm really good at Irish goodbyes
-
Smithx10
both on SunOS 7fa0a8b5-da12-477b-a1f9-870151b56edb 5.11 joyent_20260522T154557Z i86pc i386 i86pc illumos
-
rzezeski
Patrick's change: 77983a892403763fb778c095cdc6d7c5388508c9
-
rzezeski
great thing about the network is that it will resent the packets
-
rzezeski
unless it's UDP, then whatever I guess
-
rzezeski
"left package at front door" delivery
-
Smithx10
-
Smithx10
with 9k zones on src and destination anything over 1519 bytes is bumping the toolong_errors
-
danmcd
1518 looks like VLAN-tagged ethernet....
-
danmcd
Your net0 has 9000, doe the underlying NICs in the aggr have that? There isn't a network hop between them... Same questions on the receiving side.
-
danmcd
This stinks of some part of the many layers having kneecapped MTU at 1500.
-
danmcd
Check the vnic you're dealing with (both sides), check any other layers of vnic between it and either an aggr or HW link.
-
danmcd
If an aggr is involved, check the MTU on each link in the aggr... just to be sure.
-
Smithx10
@danmcd IP: Total length = 1501 bytes doesn't work IP: Total length = 1500 does. If I use a network on the same network where we don't traverse a gateway we work always
-
danmcd
And finally, does your switch do stupid things?
-
danmcd
Oh... if you're traversing a router then it isn't doing PathMTU discovery, or ICMP TOO BIG packets are getting dropped.
-
Smithx10
Not sure tho what is making our toolong_error climb? toolong_errors 9899
-
danmcd
that's on the target?
-
Smithx10
Source
-
danmcd
Then check all the way down, INCLUDING if your'e routing on-host... we should catch that. If ICMP TOO BIG messages aren't making it up?!
-
danmcd
(Dammit, why do you show up this close to dinner?)
-
Smithx10
hahah go to dinner
-
Smithx10
I'll make the gist cleaner*
-
Smithx10
-
Smithx10
Not 100% I get how 'ping -D -s 10.82.131.32 1473' is resulting in toolong_errors ... would anything of the networking infrastructure forward that to source cn?
-
Smithx10
Yikes, missing the edit button from discord on that one. bah haahah
-
jbk
so any ATAPI experts around? :)
-
jbk
apparently if the device triggers an error during attach, we end up here in a taskq:
github.com/illumos/illumos-gate/blo…n/io/sata/impl/sata.c#L10690-L10699
-
jbk
trying to get the error
-
jbk
except since we're in attach, satacmd_acdb_len is not yet set
-
jbk
so the bzero() length underflows (and saddness quickly follows)
-
jbk
the immediate fix is just bzero() the whole fixed sized buffer first
-
jbk
before the bcopy and don't bother with any math
-
jbk
but the 0 satacmd_acdb_len is still bothering me... it should be 12 or 16 (depending on what IDENTIFY PACKET DEVICE returns)
-
jbk
but since we need to just retry until we get a response
-
jbk
i'm wondering about just using 12 if we don't know
-
jbk
(I figure worst case it's going to ignore it if it really wants 16, but even that isn't clear)