-
jbki've not run them yet... not sure if my HW even has any devices that could be used
-
richlowethere are test devices, you dont need hardware
-
rmustaccI've not seen it fail, sorry.
-
rmustaccThey're part of the standard os-tests.
-
gitomat[illumos-gate] 18115 Update Intel microcode to 20260512 -- Dan McDonald <danmcd⊙ei>
-
omarrothHey! New contributor, I recently opened a new bug report 18109 and created a short CR that should resolve the issue. Wondering if there's anything else I should do to help push things along?
-
omarrothEven if it's just "rewrite the patch/add more detail", I'd be happy for any feedback
-
jbkhave you had anyone review your change?
-
omarrothnot yet, wasn't sure who to poke
-
jbkit's fairly common to ask for reviews on the illumos-developer mailing list
-
jbkthough not required
-
jbk(the requirement is just that the code needs someone else to review and approve it)
-
omarrothGotcha, I'll send something in there. I was looking at some other issues/CRs but it looks like things are a bit spread out over irc, etc. I appreciate it!
-
jbkthere's a link somewhere I don't have offhand
-
jbkbut basically once reviewed, you'll also want to update the issue w/ the testing done
-
jbkand then submit a request for integration to the illumos-advocates list and include a link to the gerrit review, a copy of the mail_msg from the build (should include a debug and non-debug build -- this is usually done in your illumos.sh file) and a link to the ticket (just makes it easier to check everything)
-
jbkif it's all good, it'll get merged (depending on how busy everyone is, may be a few days), or if there's questions, they'll let you know and you can address as needed
-
omarrothsounds good, I saw all the RTI stuff in the docs but looks like getting to that point is a bit more informal
-
jbkwe try to shrink to fit based on the size/risk of the change
13 hours ago