rmustacc: thanks for the feedback. I left a comment elucidating as to why I think the change is complete.

wacki: fyi code.illumos.org/c/illumos-gate/+/4233

→ CODE REVIEW 4233: 17400 msgfmt raises errors "invalid multibyte sequence" with illumos-88d39f6f84 (NEW) | illumos.org/issues/17400

(untested, my OI test VM is still building...)

I just started a new build and will report back whether the patch fixes the problem.

It takes a little bit longer than expected because I seem to have hit another new problem when building illumos-gate with the latest tz related changes:

/export/home/andreas/oi-userland/components/openindiana/illumos-gate/illumos-gate/usr/src/cmd/zic/zic.c:18:10: fatal error: tzfile.h: No such file or directory

dmake: Warning: Target `install' not remade because of errors

d

This does not happen with illumos-cfafba391b, though.

But illumos-68c58deb23 has this problem.

So, with the patch in place msgfmt seems to work again. At least the former failing builds are ok to build now.

wacki: Just to confirm you're referring to the version of illumos you're running or the version of illumos that you're building?

I have created a new ticket #17401 for the illumos-gate build problem with the latest tz changes.

I always try to build the latest illumos-gate.

So the version information is from the running kernel.

OK, so what you're saying is that you're running 68c58deb and failing to build 68c58deb.

Exactly

Sorry, I left out testing the subsequent build from my test plan as the build shouldn't be relying on it. I'll investigate what happened.

That is, the missing file in the proto area shouldn't impact this, but I'll figure out what happened. Sorry for the trouble.

wacki: Just to confirm this is failing for you during the tools build as well?

wacki: I've confirmed that code.illumos.org/c/illumos-gate/+/4235 gets me past the tools initial failure. I'll need to wait for a full build to complete (and have to step afk for ~2h)

→ CODE REVIEW 4235: 17401 tools zic fails to find tzfile.h after 17347 (NEW) | illumos.org/issues/17401

Yes, this happens during tools build.

I added an analysis to the ticket. Again, sorry for the trouble.

[illumos-gate] 17400 msgfmt raises errors "invalid multibyte sequence" after 17390 -- Hans Rosenfeld <rosenfeld⊙gho>

do we have anything to read the "Thermal Sensor On DIMM" TSOD? If not yet, where would be a good place to put it? A dedicated driver that fills in ksensor?

I _think_ on i86 the cpu drivers sort of do that stuff on behalf of memory

at least, I think that is where other memory failures etc end up

There's no reason not to have a pseudo driver either though, not that I can think of anyway

In general you can only read it over i2c and on most platforms it's owned by the BMC if it's there.

So there's a lot of it varies with reading dimm temperature sensors. On some AMD platforms that are new enough, you can ask to read it over HSMP, but on others it's hope it's plumbed through in IPMI.