-
jclulowIt seems somewhat reasonable to skip tests that need virtualisation support when none is available I guess?
-
jclulowAs long as it's clear to people that it passing inside a VM is basically meaningless for those tests
-
tsoome_well, yes, would need proper message in the log of course.... anyhow, other option would be to perform this check in smartos-test ;)
-
rmustaccGiven it's an entire top-level test suite, feels like probably something the wrapper there should do.
-
rmustaccI think when a set of tests requires specific hardware, it's easier to put them in a different run file. That's what I did with the nvme tests so the unit tests can always run, but the ones that require hardware are clear that they do.
-
jclulowYeah that makes sense