[illumos-gate] 16625 audio: suggest parentheses around assignment used as truth value -- Toomas Soome <tsoome⊙mc>

[illumos-gate] 16630 libsecdb: i.rbac is assuming C locale -- Toomas Soome <tsoome⊙mc>

rmustacc: currently we parse the NVMe controler 'model' field using sata_split_model() to try to extract the vendor, though that's assuming the vendor is the first 'word'

this doesn't seem to be the case for at least this Toshiba NVMe we have...

i'm wondering if it might be better to somehow leverage the vid instead of trying to parse the model string...

(or something else)

(so the vendor shows up as the fallback 'NVMe')

[illumos-gate] 16632 unix: conflicting types for 'cpuid_getchiprev' -- Toomas Soome <tsoome⊙mc>

does illumos support posix_fadvise api? I hit issue in postgresql that set effective_io_concurrency=2, then it report the platform can’t support posix_fadvise , (I use zfs on illumos), so I just want to comfirm if it is true illumos does not support posix_fadvise on zfs

best wishes

jbk: In general I think the stuff we fake for block devices is kind of odd imho.

The NVMe spec doesn't have a string name for vendors just the PCI vid in the identify controller bit.

If you passed through the vid, it'd have to be userland that did the translation into something there. We don't really want a kernel version of libpcidb.

tozhu: It's not wired up, but shouldn't error.