Hi, I ran into the problem here I believe: illumos.org/issues/16065 - How can I apply the attached patch? My system still keeps crashing, also with the line in /etc/system. Thanks!

→ BUG 16065: Panic in zfs_retzcbuf with smb2_read_zcopy enabled (In Progress) | code.illumos.org/c/illumos-gate/+/3164

are you sure it's crashing with the same issue?

got this: panicstack = unix:die+c0 () | unix:trap+999 () | unix:cmntrap+e9 () | zfs:dmu_xuio_cnt+10 () | zfs:zfs_retzcbuf+16 () | genunix:fop_retzcbuf+71 () | smbsrv:smb_vop_retzcbuf+20 () | smbsrv:smb_fsop_retzcbuf+20 () | smbsrv:smb_xuio_free+70 () | smbsrv:smb2_read+55c () | smbsrv:smb2sr_work+38f () | smbsrv:smb2_tq_work+7a () |

genunix:taskq_d_thread+1fc () | unix:thread_start+b () |

and: panicstr = BAD TRAP: type=e (#pf Page fault) rp=fffffe00f72c06a0 addr=4 occurred in module "zfs" due to a NULL pointer dereference

what distro are you running?

It was OI Hipster updated to newest version from time to time: "The illumos Project     illumos-2a6a1d830d      December 2023"

after updating /etc/system, have you tried running `bootadm update-archive` and rebooting? AFAIK making the change via /etc/system (should be persistent) or mdb (non-persistent), should completely disable that code path

running `mdb -ke 'smb2_read_zcopy/D'` should show you the current value

not yet, did not know i had to do so. The mdb from thread gives me: mdb: failed to open smb2_read_zcopy/W0: No such file or directory

 mdb -ke 'smb2_read_zcopy/D'

smb2_read_zcopy:

smb2_read_zcopy:1

yeah, it's not applying the fix

`mdb -kwe 'smb2_read_zcopy/W0'`

(Unless '-e' doesn't work with '-w' ?)

it should

the mystery is that /etc/system should be doing that on boot, but appears to not be

danmcd that does something

(why i was wondering if maybe the boot archive needs to be updated)

mdb -kwe 'smb2_read_zcopy/W0'

smb2_read_zcopy:0x1             =       0x0

yeah, that'll disable it, but is non persistent

whenever you're able to reboot, I would try the bootadm command (it can be run anytime -- it just updates the boot archive used during boot) and then rerun the mdb -ke 'smb2_read_zcopy/D' command to see what the value is

Ok, I tried the bootadm command and rebooted, but it is 1 again after that

oh.. that's strange...

i don't have an OI hipster system handy to test unfortunately..

i don't know why setting it in /etc/system isn't working

(it should basically do the same thing as `mdb -kwe 'smb2_read_zcopy/W0'` for you, but obviously is not)

but that explains why you're still getting the panic

a fix should be coming pretty soon

set smbsrv: smb2_read_zcopy = 0 in /etc/systrem ?

tried to remove the spaces in /etc/system line for that, ran bootadm and tried again but it is 1 again after reboot, so this temporary fix will hopefully help me until that. I would also test the patch, if I know how to apply it :)

err, without space after colon

tsoome: is the fix in your queue yet?

ok I'll try that tsoome

if this does not work, you can try: boot -B disable-smbsrv=true

but will this disable the whole smb server?

it is waiting for 16031 and 15985 to land first

i've been a bit out of pocket the past several days (covid :(), so haven't caught up yet

tobias61 yes, but that allows you to have usable system, so I can mail you the patched binary;)

set smbsrv:smb2_read_zcopy=0 works

ahh ok..

yes, because module variables need modulename: prefix (see system(4)

i've got the ticket up, i can add that

perhaps a hint in the issue could have helped me out with that :)

I'm currently waiting for 16031 and 15985 to get approved, but obviously the zfs hole did eat much of the attention...

big thanks for your help! will come back the next days and check if the fix works for me, if it is rolled out

yeah, i saw the emails from the tracker fly by inbetween (several) naps over the past several days

sigh. inaccessible imported data pool is making system unusable:(