ping?

pong?

Thanks. Greetings from MacOS 14 (Sonoma). libera.chat didn't like my inbound connections for a small period of time.

it was the same for everyone, i guess

That makes me feel a bit better.

My bouncer crapped out on me for 7m, I couldn't figure out what was going on.

my connection stayed up but I saw a couple bursts of "... has quit (*.net *.split)" departures.

^^^ I was probably a victim.

While trying to figure out why I couldn't connect I saw the DNS response change.

I don't know if that's part of their load balancing or someone did that to fix it.

(or fucked it up by changing it, then unfucked it by changing it back)

danmcd: I saw you leave at 20:00:29 your time in the second batch of departures (previous was 20:00:03 to 20:00:09 your time)

alanc ouch:)

alanc fortunately we do not have those variants other than in comments

oh good, seems I am not the only one prone to miss spelling variables from times to time 😅

I'm setting up for gerrit following the guide here: illumos.org/docs/contributing/gerrit

But when I try to get the Change-Id hooks with:

scp pilonsi⊙cio:hooks/commit-msg .git/hooks/

It fails with subsystem request failed on channel 0

I can successfully connect through ssh otherwise

Try 'scp -O ...'? (I suspect the old vs new scp protocol mismatch.)

Yes that was it, thank you!

I have pushed my changes for 15839 to gerrit: code.illumos.org/c/illumos-gate/+/3052

→ CODE REVIEW 3052: 15839 Erroneous newline in error message (NEW) | illumos.org/issues/15839

Though now I see I'm going over the max line width, and also it mentions that there is a merge conflict so I'll get to those

you can do something like x = "foo bar" " baz"; in C and the compiler will combine those segments for you

(the segments can even be on separate lines)

pilonsi - nice, that's good progress :)

In that case I'd probably put the entire string on the next line. I think it's useful to keep strings together to aid grep and so on.

(I know not everyone who contributes takes that approach)

Thanks! :)

I've noticed though that the same thing appears in several other prints in that file

Should we fix those too for consistency?

Like likes 1556 1557

There are other lines that do use the "foo"\n "bar" solution

Oh yes, I'd fix any others that try and use \ continuation.

* likes --> lines

I'd also look at what `git pbchk` reports as there might be some other things in that file worth fixing up. Some of the older code doesn't quite use the right style and so on, and we try and fix it up as we pass.

Nice, I'll get to it

It isn't mandatory to fix up code you aren't touching, but definitely worth doing if you can.

Should I add a comment to that issue and keep all changes to that, or add a new one and fix both in the same commit?

Same issue is fine.

When I run git pbchk

I get this:

usr/src/uts/common/io/kbtrans/kbtrans_streams.c: 1474: continuation should be indented 4 spaces

If I indeed indent the continuation by 4 spaces they go away

But in the other statements in the code, the continuation is indented 4 spaces starting from the indentation the 1st half already had

(Which I also think looks nicer)

an additional 4 spaces for a continuation line is what's required by the style checker.

additional to the indentation level of the line that is being continued, that is

It's tabs up to the level of the previous line, then four spaces.

Aah.. I see, I was doing all tabs, since i have them set to 2 spaces it matched nice

Thanks

But its worth mentioning that doing 2 tabs (4 spaces) from zero made the error go away

When the second line was indented less that the parent one

I've pushed the new fixes, it's no longer complaining

Should I ask in the mailing list for a review?

(btw, what's the difference between illumos-devel and illumos-advocates?)

Yes, that's the best way - illumos-dev

the advocates list is where you would send the patch for integration once you have enough reviewers and have tested etc.

"advocates" is the old name for what is now the "illumos core team"

andyf: thanks for the review! Now it's just doing the full nightly build, and asking in the advocates list right? (Do i have to be in the list, or can I just send an email directly?)

That's right, you can just send.

There are a few things to include in the email - the contribution guide should cover it - and you need to put testing notes in the issue.

Testing is shrink-to-fit though, so for something like this I would expect that a full nightly build and maybe running strings on the binary to check they look ok there would be enough.

(the advocates have the last word, but they're a friendly bunch)

It's usually good idea to let changes sit in review there for a while to give anyone who wants to look at it a chance, across time zones etc.

But that also depends on the size/complexity of the change.

That's ok for me! I'll leave it overnight

About the testing notes... With the issue you mean as a comment on the bugtracker? Or in the email I send to the advocates list?

And what do you mean by running strings? Inspecting the data section of the binary to get the strings?

A comment in the bug is best.

Yeah, we want the notes preserved there

Got it

Some folks also choose to transcribe the testing notes into the RTI email, but that's purely a preference thing vs "Testing notes are in the ticket(s)"

pilonsi - I meant inspect the strings in the final build via one means or another. For this change literally running the `strings` command against the old and new `/kernel/misc/amd64/kbtrans` is probably enough - it's just a smoke test.

defaulit

delaut was the better one

defalt

delfut

none of either of those in my tree;)

now, it is time to hunt for forgotten RTI's...

if I were hunting bugs, implicit-function-declaration still holds the most horrors

types? who needs them.

defalt as a function argument was presumably an attempt to avoid a keyword.. I definitely prefer the change to def_val tsoome

ou yes:)

yea, I figured that too

like C++ being klassy with a k