Guten Morgen / Bonjour / Доброе утро / Good morning.

hello :)

[illumos-gate] 15064 vmm: unused variable 'iommu_initted' -- Toomas Soome <tsoome⊙mc>

should the string passed to nvlist_add_string() stay intact? i.e. i have the following code: val = strdup(someval); fnvlist_add_string(nvl, "name", val); <- can/should i free() val now?

yuripv: It copies the string into the nvlist yeah

so you can free it

I think that's true of anything you pass into nvlist adds

thanks!

so that strdup() is not needed as well

You should be able to pass "someval" right into fnvlist_add_string() as it'll do the strdup for you.

thanks guys (going over some old code and these strdup/nvlist_add_string/missing free got my attention)

[illumos-gate] 15044 SMB should return NT_STATUS_FS_DRIVER_REQUIRED for DFS ioctls when DFS is not supported -- Gordon Ross <gwr⊙rc>

[illumos-gate] 15045 SMB should implement FSCTL_DFS_GET_REFERRALS_EX -- Gordon Ross <gwr⊙rc>

[illumos-gate] 15046 libc: unused variable -- Toomas Soome <tsoome⊙mc>