libre #2600hz

21 Dec 2022

KAZOO: Cloud-Based Telecom for Everyone | github.com/2600hz/kazoo | forums.2600hz.com | docs.2600hz.com/dev | Bi-weekly community call at parley.2600hz.com/?autocall=mod-community (see forum calendar for dates and time)

• 18:27
  barney_
  is anybody using any of the knm_carriers to acquire numbers ?
• 18:27
  barney_
  mc_? ^
• 18:37
  barney_
  Trying to acquire a number, but I can't see that anything calls ?CARRIER:acquire_number
• 19:07
  mc_
  barney_: i think there's a sys config for number_manager for default carrier module
• 19:07
  mc_
  and the phone_numbers API
• 19:08
  mc_
  we use knm_bandwidth2 i think?
• 19:08
  barney_
  I am using knm_simwood - searching for numbers works
• 19:09
  barney_
  but when I try and activate via cb.. it seems to search the numbers db and returns bad identifyrer the number could not be found
• 19:09
  barney_
  knm_search:433(<0.5271.140>) error requesting number from amqp: timeout
• 19:09
  barney_
  should there be something listening for this published amqp ?
• 19:11
  barney_
  docs.2600hz.com/supported/applicati…ers/#buy-a-number-once-searched-for
• 19:11
  barney_
  "once searched for" seems to lead me to think that something is supposed to cache a previous search?
• 19:14
  mc_
  barney_: could be, i haven't worked in there for a while so rusty on particulars
• 19:14
  mc_
  but compare simwood to bw2 modules to see if they search/acquire diff
• 19:15
  barney_
  ok will do thanks mc_
• 22:02
  barney_
  cb_phone_numbers is add a sodding + to the number so it's not matching the ETS table :S
• 22:06
  mc_
  barney_: in general kazoo likes to deal with E164 internally, and convert to expected formats before sending numbers out of kazoo
• 22:07
  barney_
  E164 (without the +) I assume
• 22:08
  barney_
  /v2/accounts/{$account_id}/phone_numbers/{$ddi}/activate
• 22:08
  mc_
  with the +, so "4158867900" would be converted to "+1415867900" for internal handling
• 22:08
  barney_
  DDI is 44XXXXXXXXXX
• 22:08
  mc_
  yeah, presumably that would become +44...
• 22:09
  barney_
  ok.. so you'd expect the ETS table key to be +44
• 22:09
  mc_
  yeah, the numbers dbs are the first 5 chars, so "+44\\d{3}"
• 22:09
  mc_
  then knm_simwood would convert to whatever simwood API expects the format
• 22:11
  barney_
  Num = list_to_binary([kz_json:get_binary_value(<<"country_code">>, JObj)
• 22:11
  barney_
  ,kz_json:get_binary_value(<<"number">>, JObj)
• 22:11
  barney_
  ]),
• 22:12
  barney_
  so that's the issue... (country_code) is just 44
• 22:13
  mc_
  look at using `knm_converters:normalize(Num)`
• 22:13
  barney_
  simwood returns <<"44">>, <<"1444XXXXXX">>
• 22:13
  barney_
  ok thanks
• 22:13
  mc_
  should build it back to +441444...
• 22:16
  barney_
  mv_
• 22:16
  barney_
  response_jobj_to_number(JObj, QID) ->
• 22:16
  barney_
  Num = list_to_binary([kz_json:get_binary_value(<<"country_code">>, JObj)
• 22:16
  barney_
  ,kz_json:get_binary_value(<<"number">>, JObj)
• 22:16
  barney_
  ]),
• 22:16
  barney_
  Num2 = knm_converters:normalize(Num),
• 22:16
  barney_
  {QID, {Num2, ?MODULE, ?NUMBER_STATE_DISCOVERY, JObj}}.
• 22:16
  barney_
  Works like a dream! thanks :)