02:20:14 https://pastebin.com/3d0uf2Mn has some mostly trivial things you could fix in the illumos man pages, mostly in section 4M (kernel modules that aren't drivers, filesystems, network protocols, etc.) 05:24:26 [illumos-gate] 17884 loader.efi: tss_pa setup seems to be flawed in trap.c -- Toomas Soome 05:26:44 [illumos-gate] 17885 loader.efi: free_tables() appears to free tss_pa twice. -- Toomas Soome 05:28:30 [illumos-gate] 17886 loader.efi: efi_redirect_exceptions does use uninitialized pointer -- Toomas Soome 17:04:52 most trivial fix in a while (single-character deletion fixes the bug): https://code.illumos.org/c/illumos-gate/+/4582 17:04:52 → CODE REVIEW 4582: 17888 pargs botches composite locale naming (NEW) | https://www.illumos.org/issues/17888 17:06:16 I still like my one fix which was almost as trivial that fixed the random lockups during boot on my home server 17:07:30 I think it was there was some locking of the CPU structs right below a comment and statement that said 'don't do any further locking below this line' 17:07:47 and sure enough, the fix was to move the offending line so it wasn't below it :) 17:07:57 Really drives home the "all the details matter" aspects of what we do. 17:09:34 oh i misremebered it slightly 17:09:39 https://github.com/illumos/illumos-gate/commit/af1da5d88749a7acca42afebc5b3ca9ec806c095 17:09:39 → GitHub commit af1da5d: 9760 mp_startup_common races itself (committed) 17:10:27 we were creating the device node after what was supposed to be the last thing for initializing the cpu 17:13:16 jbk: oof, yes. boot cpu sees the bit flip, starts looking at the new cpu's device node and it's only half built... 17:13:43 but so thoughtful for the original commenter to point out the problem right by it :) 17:14:00 'don't do X' 'ok' 17:14:39 yeah, for me that would trigger the "how did this ever work" investigation... 17:41:00 yeah, i was surprised more people didn't hit it... there was something with my system though that managed to get the timing right to hit it frequently 18:41:38 [illumos-gate] 17882 lpsched confuses RO and RW memory, and core dumps -- Andy Fiddaman 20:14:40 tsoome: am I correct in thinking we use multiboot2_loadfile() to load everything into memory (at least initially before we copy or such)? 20:15:15 I just went through some stuff in .../copy.c that does that, with toomas' help, merging 20:16:41 [illumos-gate] 17888 pargs botches composite locale naming -- Bill Sommerfeld 20:18:47 I think that's what loads unix, but I'm less clear what loads the boot archive into memory.. 20:27:06 danmcd: do you recall if the mlxcx work you did included cx-7 support? 20:55:47 do any of you recall whether page relocation is exclusively a kcage artifact? 20:57:22 I don't *think* so but I'm not 100% sure. Easiest way to check is consult the mlxcx driver aliases info in the .p5m file. 20:57:52 unfortunately, I don't have the PCI ids, just vendor model #s at this point 20:58:07 does the pci db not tie that together? 21:01:13 You mean like https://admin.pci-ids.ucw.cz/read/PC/15b3 ? 21:01:27 It *should* but sometimes the user-reported data is incomplete or even erroneous. 21:04:00 ahh if only 21:04:13 you forget.. every OEM has to have at least 4 different names for the same part 21:05:30 i suspect if we don't have 'general' cx-7 support, than just the fact it says it's some sort of cx-7 card is enough that it won't work 21:09:37 I have a PRM that includes CX-7 but it's shared with us by a buys-a-lot-of nVidia customer. 22:29:10 i have to ask.. https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/i86pc/vm/kboot_mmu.c#L52-L56 who's Joe? :) 23:02:36 the hg/git logs point to a large, multi-person putback, but when I see "Joe" in a file under i86pc/vm my mind first goes to Bonasera 23:24:25 richlowe: would that be used to retire a DIMM as well? 23:26:50 (assuming we had all the bits plumbed up to do it... i'm not sure we're there for some systems since they'd need more ACPI integration IIRC)