10:54:48 <andyf> ptribble - re 17453 (fenix) I think that's clarifying rather than muddying. I can stop looking at differences between the forks at least. The values from the test program vary on OmniOS/Helios but they seem to always be page aligned, unlike the other systems.
10:55:03 <andyf> illumos 17453 fenix
10:55:04 <fenix> BUG 17453: ed(1) segfaults on writing empty file (In Progress)
10:55:04 <fenix> ↳ https://www.illumos.org/issues/17453 | https://code.illumos.org/c/illumos-gate/+/4282
11:05:26 <ptribble> It's definitely a weird one! Glad I can help shine a little light on mapping this particular rabbit hole.
12:31:10 <andyf> It's apparently due to omnios/helios having ASLR enabled on sshd. If I log in on the console, I see the same behaviour as tribblix et al.
12:32:35 <andyf> https://github.com/omniosorg/omnios-build/blob/master/build/openssh/files/ssh.xml#L110
12:33:23 <tsoome> .oO oops.
12:34:35 <andyf> Could you try `pfexec psecflags -s aslr $$` in your shell and see if it changes things?
12:34:59 <andyf> https://paste.omnios.org/?41e97272cf18af08#FSPKJYnLyDkTXi62yDxus9Xobn8BS1WRbqMbve5ZYwGR
12:40:02 <tsoome> Segmentation Fault (core dumped) (on OI)
12:40:05 <ptribble> Bingo!
12:40:32 <ptribble> With that, reproduces on Tribblix.
12:40:57 <kwaltz> I would never in a million years have expected this. what a journey andyf
12:41:15 <andyf> https://github.com/illumos/illumos-gate/blob/master/usr/src/uts/common/exec/elf/elf.c#L1563-L1573
12:53:21 <andyf> kwaltz - thanks for reporting it. It's a real bug in ed(1) and my proposed fix is at https://code.illumos.org/c/illumos-gate/+/4282. I can give you a hotfix for OmniOS if you'd like, otherwise it will be updated next time OmniOS has a weekly release.
12:53:22 <fenix> → CODE REVIEW 4282: 17453 ed(1) segfaults on writing empty file 17455 Add CTF data to ed(1) (NEW) | https://www.illumos.org/issues/17453
12:56:37 <kwaltz> thank you so much andyf! I'll be sure to grab the release when it comes out
16:45:17 <danmcd_> Thanks for finding this @kwaltz .
16:49:35 <jbk> heh.. i wonder how long that bug has been there
16:56:00 <ptribble> Oh, ed crashes the same way on Solaris 11.4, once I worked out the magic incantation (using sxadm) to disable aslr
17:07:10 <alanc> oh, so it does
17:42:50 <danmcd_> With C99 `bool`, is there a reason we couldn't get rid of `boolean_t` in illumos?
17:43:22 <andyf> It's probably a bit tricky. It's part of the MAC interface for example.
17:43:43 <danmcd_> Dammit, was mid-typing "existing interfaces?" and yeah, I guess so.
17:44:30 <andyf> The ena driver has a nice mix of boolean_t and bool for that reason.. Well, I converted everything I could to bool.
17:44:32 <danmcd> "sizeof (bool) != sizeof (boolean_t)" which matters for existing interfaces (i.e. what I was typing).
17:44:44 <danmcd> I SAW that in ena(4D).
17:45:43 <danmcd> (I don't think we have any frequently-allocated structures where adding more <<HOLE>> is horrid, but that we have <<HOLE>> in things bugs me, probably irrationally, and it's now in my same headspace as precision-data-layout in a language...)
17:53:02 <rmustacc> The boolean_t is part of the ABI for many things and where it's part of that ABI, it can't change.
17:53:18 <rmustacc> Also depending on what you care about, you cannot build C89 software with bool present generally speaking, unlike other extensions.
18:52:08 <richlowe> rmustacc: we should probably have a sys/bool.h rather than stdbool, for uts, too?
18:52:41 <richlowe> or does sys/stdbool.h end up behaving fully?
18:52:48 <richlowe> headers that smell of userland scare me
19:27:38 <gitomat> [illumos-gate] 17307 ufs/newfs: dprintf() cleanup -- Hans Rosenfeld <rosenfeld⊙gho>
19:33:56 <rmustacc> richlowe: <sys/stdbool.h> was the one that the kernel can safely use.
19:34:18 <richlowe> ah, just the 'std' giving me the fear
19:34:40 <rmustacc> I think of it like <sys/stdint.h>.
19:43:04 <gitomat> [illumos-gate] 17444 gitignore doesn't know findunref -- Patrick Mooney <pmooney⊙pc>