03:18:38 <tozhu> hello all, I have question on this link:  https://pastebin.com/NjQT1Wy4 , any advice?  best wishes
11:26:34 <yuripv> hm, how do I tell gcc that cmn_err(CE_PANIC, ...) does not return? it whines that "control reaches end of non-void function" otherwise
11:55:45 <paulf> https://en.cppreference.com/w/cpp/language/attributes/noreturn ?
11:56:14 <paulf> or just return something
11:57:27 <yuripv> well, my point was not having useless return :)
14:03:14 <jbk> it is a bit annoying since it appears smatch understands but gcc does not
14:03:36 <jbk> i've had to add a superfluous return surrounded by #ifndef __CHECKER__ to make everything happy
17:29:58 <jclulow> yuripv: You _could_ just call panic()
19:51:43 <richlowe> yeah, there's no valid way to say "returns _sometimes_" in a way the compiler fully understands
19:51:55 <richlowe> you can return once, never, or more than once.
19:52:31 <richlowe> this is basically the thing sommerfeld ran into with ASSERT()
19:52:41 <richlowe> but rather than `aok` it's the flag argument 
19:55:51 <vetal_> Hey! Is it possible to increase iscsi target tcp rcv buffer size? Setting it via 'ipadm set-prop -p recv_buf=1048576 tcp' and 'svcadm restart iscsi/target' do not change that for the tcp socket.
19:57:45 <richlowe> sommerfeld: I looked at your rationale for nightly bringover of git, and you're basically avoiding all the points that caused me to not do in the first place.  (I'm not sure if `git worktree` even existed then).
19:58:05 <richlowe> seems really handy, with those limitations placed on it.
19:58:27 <vetal_> Probably iscsi target sets it some another way, however tcp_create_common() is executed when do "svcadm restart iscsi/target"
20:00:48 <richlowe> sommerfeld: a suggestion, though I haven't looked at the code yet... if we could specify bringover/target ws on the nightly command line, you could share an env file and just say `nightly --parent /builds/richlowe/arm64-gate/illumos/gate --builddir /tmp/foo env/shared`
20:01:33 <richlowe> (I'm aware I could do that setting CODEMGR_WS and BRINGOVER_WS on the command line, it just seemes neater not to)
20:21:18 <sommerfeld> richlowe: yeah, I haven't shared my WIP just yet.   
20:22:32 <sommerfeld> Good idea to put the dirs on the command line - I'll consider doing that as a separate change.
20:24:14 <yuripv> jclulow: thanks, that's what I did eventually, just thought that it's somewhat "unclean" as cmn_err() seems to be used much more than panic()
20:24:56 <sommerfeld> I'm not using `git worktree` as a git branch can IIRC only be checked out in one worktree of a repo at a time.   using the objects/info/alternates mechanism is nearly as lightweight as worktrees.
20:27:43 <sommerfeld> richlowe: unlike aok, the cmn_err(CE_PANIC, ..) thing is at least theoretically possible for an sufficiently advanced compiler to get right because it's (almost always) a compile-time constant at each call site rather than a global variable that can be patched in /etc/system or kmdb..
20:39:59 <sommerfeld> richlowe: anyhow, back to "bringover_git": I'm curious about what gotchas you were thinking of (I have my own but I'd like to hear more on why you punted)
20:44:38 <richlowe> I punted almost entirely because I couldn't think of a way for merging to work out right, or even ok
20:45:47 <richlowe> the former joyent people might remember more details, they were big on git.
21:05:40 <jclulow> I keep forgetting about "aok"
21:05:47 <jclulow> Probably to protect myself