14:18:11 <jbk> i have some simple changes that address most of the (currently suppressed) compiler warnings in mac, but there are a few bits i'm unsure of (and might require more digging, depending on time)... would it be worth throwing up what I have that's pretty straightforward (mostly just initializing values)
14:18:22 <jbk> even if it's not entirely complete?
14:50:39 <andyf> I'm all in favour of removing warning suppression, yes please, and I can work through it - I'm always wary of changes that just initialise values :)
14:59:18 <jbk> i did go through and look at the relevant code for these
14:59:36 <jbk> that's why there some that i wasn't sure about and left them
15:00:11 <jbk> (well for some unrelated work, i do have a separate change i'm not planning to put up for now that just quiets them only so i can build my changes to make sure they don't add any)
15:00:16 <andyf> I didn't mean to imply you didn't, bad choice of words there. I just meant that I always give them a bit more scrutiny and I'm happy to review.
15:03:46 <jbk> https://github.com/illumos/illumos-gate/commit/8e1b7a312309e8e88884c4ce16a3139be0b5aec8 if you want a preview
15:16:28 <jbk> there's actually one (not in that change) that I'm completely baffled by: https://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/io/mac/mac_client.c?r=119d61cc&mo=87558&fi=3057#3057
15:16:55 <jbk> it's complaining that on line 3207, flent is uninitialized (which it is)
15:17:35 <jbk> oh wait.. i guess i just rubber ducked it
15:18:05 <jbk> that argument is completely ignored in mac_client_datapath_teardown
15:18:28 <jbk> (or i guess overwritten before any passed-in value is ever used)
15:20:33 <jbk> .... which i guess brings up why it's a parameter in the first place if it's not used
15:20:45 <jbk> it doesn't look (from first glance) to be something that's used as a callback
15:29:54 <andyf> I agree with what you've said. The other call site for mac_client_datapath_teardown passes in what will be used anyway. Looks to me like the parameter could be removed.
15:52:25 <jbk> yeah..
15:52:40 <jbk> let me update that branch with that, plus a few other things I missed
15:54:11 <jbk> now the only thing left is this: https://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/io/mac/mac.c?r=2aaafd60&mo=179446&fi=6756#6882
15:54:15 <jbk> we're ignoring the return value
15:54:46 <jbk> but i'm not sure if we should just continue to do that, or if we should try to 'undo' what was done earlier
15:54:53 <jbk> like some of the earlier code in the function
15:55:09 <jbk> though it's all for functionality that seems to only be present on some NICs that I think were sparc-only
15:55:45 <jbk> and i don't want to just silence it if that's a legitimate bug
15:55:49 <jbk> that's been masked
21:26:31 <gitomat> [illumos-gate] 15986 svcs can stumble over file dependencies -- Mike Zeller <mike⊙mn>
23:28:09 <gitomat> [illumos-gate] 15995 2GB arc_c_min ceiling should be 1GB -- Dan McDonald <danmcd⊙mi>