07:28:05 <gitomat> [illumos-gate] 15594 smb_node_alloc calls fsop_root excessively -- Gordon Ross <gwr⊙rc>
16:15:32 <sommerfeld> good morning.  I'd appreciate it if someone could look at my RTI for https://code.illumos.org/c/illumos-gate/+/2891
16:15:33 <fenix> → CODE REVIEW 2891: 15713 ulwp32_t is out of sync with ulwp_t (NEW) | https://www.illumos.org/issues/15713
16:35:03 <pmooney> sommerfeld: I'm looking at that RTI.  Do you have the details from the wsdiff which listed the three functions you referenced?
16:40:51 <sommerfeld> yes.   
16:41:45 <sommerfeld> I can re-share it but I attached it as wsdiff.15713 to the RTI email.
16:43:10 <sommerfeld> the changes to td_ta_thr_iter and td_thr_get_info are obviously sizeof changes.   the td_thr2to32 change is as well (the code sequence is a tricksy branchless thing)
16:47:24 <sommerfeld> context is : td_thr2to32+0xa5:               sbbl   %eax,%eax
16:47:24 <sommerfeld> td_thr2to32+0xa7:               andl   $0x124,%eax
16:47:24 <sommerfeld> td_thr2to32+0xac:               addl   $0x18c,%eax
16:47:24 <sommerfeld> td_thr2to32+0xb1:               movl   %eax,0x38(%rbx)
16:47:24 <sommerfeld> td_thr2to32+0xb4:               cmpb   $0x0,0x7e(%r12)
16:48:19 <sommerfeld> which is the code corresponding to         ti_p->ti_ro_size = ulwp->ul_replace?
16:48:20 <sommerfeld>             REPLACEMENT_SIZE32 : sizeof (ulwp32_t);
16:49:13 <gitomat> [illumos-gate] 15688 blkdev and lofi need to properly init cmlb minors -- Robert Mustacchi <rm⊙fo>
17:18:03 <sjorge> jperkin on the up side the no go carbon stuff seems to at least mostly build in a venv, except carbon-web which struggles with cffi and stuff -_- why can't we just have nice things wrt software portability
17:37:32 <pmooney> sommerfeld: ah, please attach that to the ticket?
17:37:47 <pmooney> (since it's a valuable part of the test notes)
17:38:07 <sommerfeld> one moment...
17:49:11 <sommerfeld> done
18:41:10 <gitomat> [illumos-gate] 13180 Remove printmgr, as it doesn't work with any current java -- Peter Tribble <peter.tribble⊙gc>
18:44:44 <gitomat> [illumos-gate] 15713 ulwp32_t is out of sync with ulwp_t -- Bill Sommerfeld <sommerfeld⊙ame>
18:48:52 <sommerfeld> pmooney: Thanks!
19:27:29 <jbk> hrm.. when doing a scrub or resilver, if i'm reading this right, cv_broadcast() is called after every I/O... that seems excessive
19:28:03 <richlowe> I mean, depends on who it's waking?
19:28:08 <richlowe> and why
19:28:32 <jbk> it's part of it's rate limiting
19:28:52 <jbk> (which is unforuntately has some other flaws)
19:29:03 <jbk> i think there'll be either 1-2 threads blocked
19:47:21 <gitomat> [illumos-gate] 15722 which_scm confused by git worktree -- Bill Sommerfeld <sommerfeld⊙ame>
22:32:31 <gitomat> [illumos-gate] 15718 Fix bad references in ufm manuals -- Robert Mustacchi <rm⊙fo>