00:35:39 <jbk> should we perhaps ship usr/src/cmd/mdb/common/modules/conf/mapfile-extern ?
00:35:50 <jbk> (or package I guess)
00:36:11 <jbk> (to help any unbundled mdb modules)
06:01:37 <danmcd> Heh heh.  fenix illumos#15655 breaks the smartos build as we set MAKEFLAGS in our smartos-live generated env file, but until this fix it was ignored by bldenv & nightly.
06:01:38 <fenix> BUG 15655: Build scripts should tolerate make -w (Closed)
06:01:38 <fenix> ↳ https://www.illumos.org/issues/15655 | https://code.illumos.org/c/illumos-gate/+/2851
06:02:03 <danmcd> (Lucky us, easy fix is to add 'e' to our generated envfile's MAKEFLAGS.)
09:11:26 <andyf> Slight fallout from illumos 15655 (fenix)
09:11:27 <fenix> BUG 15655: Build scripts should tolerate make -w (Closed)
09:11:27 <fenix> ↳ https://www.illumos.org/issues/15655 | https://code.illumos.org/c/illumos-gate/+/2851
09:11:31 <andyf> https://www.illumos.org/issues/15663
09:11:32 <fenix> → BUG 15663: bldenv fails with shipped .env files after 15655 (New)
14:54:24 <sommerfeld> andyf / danmcd: I'll get a fix for this out for review today
14:58:40 * danmcd finally wakes up
14:59:13 <danmcd> Oh wow, not just me then.  Okay, thanks @sommerfeld for jumping back on this.  (I thought it was a feature not a bug.)
15:05:32 <tsoome> hm, can any advocate look on 15588 pretty please?:)
15:15:46 <pmooney> tsoome: looking now
15:15:55 <tsoome> thanks:)
15:36:23 <danmcd> I think there was a period where for some bizarre reason I was not receiving RTI emails (checked my end for spam-filter failures and nothing... no idea).  15588 and at least one other (which I approved after reading the archives) were in that window.
15:52:48 <tsoome> no problem at all:) 
15:53:05 <tsoome> I need to poke richlowe too, I guess:D
16:00:19 <pmooney> tsoome/gwr: Did anyone do ::findleaks measurements while testing the 15588 bits?
16:00:40 <pmooney> (if so, could you toss a note about it on the ticket)
16:02:08 <pmooney> not strictly necessary, I don't think, but would be a nice feel-good addition
16:15:02 <andyf> Thanks sommerfeld, I think adding 'e' as you've said is definitely the best approach.
16:18:36 <danmcd> I concur Re: `bldenv will append an e if one is not present in MAKEFLAGS`
16:29:52 <sommerfeld> notably this will make a developer-visible change that predates 2005 finally take effect under bldenv (putting k in MAKEFLAGS, from the setting in the env file which was previously overridden by bldenv)
16:39:56 <rmustacc> That's not great.
16:40:08 <rmustacc> I think bldenv wants to still not have -k there if it can.
16:40:21 <rmustacc> Otherwise it's always building with -m serial to figure out what's going on.
16:40:40 <rmustacc> But fixing this is more important.
16:41:20 <sommerfeld> https://code.illumos.org/c/illumos-gate/+/2857
16:41:21 <fenix> → CODE REVIEW 2857: 15663 bldenv fails with shipped .env files after 15655 (NEW) | https://www.illumos.org/issues/15663
16:42:11 <sommerfeld> It really depends on what you're using bldenv for ...
16:43:10 <rmustacc> I mean, I use it for trying to develop and figure out why I screwed up and the dmake -m serial in unix / genunix is already painful sometimes, but that's not important compared to the build confusion I think a couple of us hit.
16:43:58 <rmustacc> Regardless, thanks for turning around quickly on this.
16:44:10 <sommerfeld> No problem, and as I said, sorry for the mess.
16:50:28 <sommerfeld> I'll be back in about 45 minutes.
16:55:52 <danmcd> 45mins will be more than enough time to see if this fix alone cures what's ailing SmartOS.  (And if it doesn't I'm ready to better-generate the env file in smartos-live.)
17:23:14 * danmcd is belt-and-suspenders-ing it:  https://github.com/TritonDataCenter/smartos-live/commit/b0f7c18616db85de35e654d46e8d2641bcb4c1a8
17:34:31 <gitomat> [illumos-gate] 15588 Improve efficiency of smb_ofile_lookup_by_fid -- Gordon Ross <gwr⊙rc>
17:36:26 <sommerfeld> rmustacc: I think the right thing to do for -k is to move it from the env files into nightly.  
17:38:44 <rmustacc> It may make sense in bldenv too. I realize that's just my gut reaction going, so may not be worth judging by that.
17:42:01 <sommerfeld> So there are two distinct use cases - "batch" and "interactive" compiles.  Batch clearly wants -k; Interactive often doesn't (when I'm doing whack-a-mole fixes I generally run with -k first followed by a series of builds w/o -k)
17:43:06 <sommerfeld> I note that our make has a -S flag which undoes -k
17:43:19 <sommerfeld> (and gmake has that as well)
17:43:44 <sommerfeld> so interactive "make -S" when you don't want to keep going.
17:44:36 <sommerfeld> (hadn't noticed that flag before)
17:44:55 <sommerfeld> so if you can retrain your fingers to type "make -S" we can leave -k in MAKEFLAGS
17:45:35 <rmustacc> As long as we are making a purposeful decision, I will adapt.
17:47:12 <sommerfeld> (and, oddly, poking through make's "main.cc": it looks like there's another undocumented way to do it: make -~k)
17:48:18 <sommerfeld> -S appears to be in POSIX, and GNU make accepts it.
17:49:04 <richlowe> wow, not even +k?
17:49:06 <richlowe> make people, why
17:49:50 <sommerfeld> (look for "invert_this" in usr/src/cmd/make/bin/main.cc)
17:50:46 <sommerfeld> I'll summarize the discussion here when I send 15663 for RTI, and capture it in the bug.
17:58:46 <danmcd> Thank you.
20:10:38 <sommerfeld> Just sent RTI 15663
20:11:26 <sommerfeld> Also, I sent an RTI for 15659 yesterday that I haven't seen any response on yet.
20:17:08 <richlowe> I was just telling people that I could approve them, but don't have the ability to run a test build of my own right now.
20:18:38 <richlowe> so if someone gets back to me on their feelings about that I can do the -Wformat one
20:18:49 <richlowe> I was hoping to leave the bldenv one to someone who had views on the chat above.
21:12:08 <danmcd> fenix illumos#15659
21:12:10 <fenix> BUG 15659: libc genassym needs -Wformat fixes (In Progress)
21:12:10 <fenix> ↳ https://www.illumos.org/issues/15659 | https://code.illumos.org/c/illumos-gate/+/2852
21:12:28 <richlowe> I approved that, and robert I think was going to deal with it because of my temperature issues
21:12:41 <danmcd> Doing a local build for that now @sommerfeld.  As for bldenv one, I'm a reviewer & tester so I'd prefer someone not-me to RTI-approve that.
21:12:51 <danmcd> fenix illumos#15663
21:12:52 <fenix> BUG 15663: bldenv fails with shipped .env files after 15655 (In Progress)
21:12:52 <fenix> ↳ https://www.illumos.org/issues/15663 | https://code.illumos.org/c/illumos-gate/+/2857
21:12:59 <richlowe> the other I was leaving alone because I didn't keep track of the bldenv opinions, and I don't myself have one 
21:53:23 <gitomat> [illumos-gate] 15659 libc genassym needs -Wformat fixes -- Bill Sommerfeld <sommerfeld⊙ame>
23:02:28 <gitomat> [illumos-gate] 15663 bldenv fails with shipped .env files after 15655 -- Bill Sommerfeld <sommerfeld⊙ame>
23:13:20 <sommerfeld> Draft heads-up in https://gist.github.com/Bill-Sommerfeld/e8b95c0600255e833a0fd45d19b94878