00:02:58 how does illumos work on other architectures? I heard that there are still a few binaries that are still closed source, and I was wondering what the future of illumos looks like. 00:05:11 there's a few that are probably not often used (pax) or specific to x86 00:05:24 or sparc 00:09:32 I'm going to pretend I know what that means and say "cool" 00:11:24 pax is like at&t (I think) decided to rewrite 'tar' (sort of) 00:11:36 so no one really uses it 00:12:16 oh I see. sounds completely useless for 99% of all users. 00:13:27 there are other pax implementations 00:17:58 I just installed OpenIndiana for the first time :D Wish me luck on my journey to set it up so that you don't see me again for mundane reasons 01:04:41 I thought pax was invented by the POSIX committee to settle all the arguments between the different tar & cpio implementations 01:05:41 insert https://xkcd.com/927/ here 01:13:31 glad to see everyone loves xkcd as much as I do 10:58:27 alanc: that's what I thought too 14:23:30 [illumos-gate] 15633 libsocket: getallifaddrs() can die with NULL pointer dereference -- Toomas Soome 14:26:58 [illumos-gate] 15604 gprof: clean up warning gags -- Toomas Soome 14:36:17 [illumos-gate] 15491 libipadm: the comparison will always evaluate as 'true' -- Toomas Soome 14:38:29 [illumos-gate] 15607 pvs: clean up warning gags -- Toomas Soome 14:56:37 is it just me, or is gerrit currently broken? 14:56:45 error: remote unpack failed: error Missing tree 59fb78569e94f0b5ae4bd384b9194549eb82e5a4 15:09:16 Woodstock: i wonder if that's related to the out of sync thing from yesterday 15:09:43 Woodstock - I've been getting that for weeks, and others have reported it too 15:09:45 the workaround is.. 15:10:04 add `--no-thin` to the end of your command line 15:10:40 thanks 15:13:24 Hey @Woodstock -- have you looked at https://code.illumos.org/c/illumos-gate/+/2716 aka fenix illumos#15483 ? 15:13:25 → CODE REVIEW 2716: 15483 remove circular from ndi_devi_enter et al (NEW) | https://www.illumos.org/issues/15483 15:13:58 I'm curious about your newly-filed fenix illumos#15638 and if one influences the other (or hopefully not). 15:13:59 BUG 15638: panic in scsi_hba_ioctl() (New) 15:13:59 ↳ https://www.illumos.org/issues/15638 | https://code.illumos.org/c/illumos-gate/+/2841 15:14:28 danmcd: i checked this and they are unrelated 15:14:36 YES! THANK YOU! 15:14:51 It looks like the previous issue 15463 (fenix) added the assertion that exposed this bug though, which is a nice result. 15:14:52 BUG 15463: ndi_devi_enter et al can be safer and clearer (Closed) 15:14:52 ↳ https://www.illumos.org/issues/15463 | https://code.illumos.org/c/illumos-gate/+/2699 15:17:33 [illumos-gate] 15314 bhyve state restore should be safe -- Patrick Mooney 15:50:26 [illumos-gate] 15483 remove circular from ndi_devi_enter et al -- Dan Cross 16:28:28 andyf/Woodstock: doing a "git fetch" on the Gerrit remote prior to the push may also avoid/work around the "missing tree" error. 16:31:47 .oO ../../intel/os/archdep.c:186:1: error: 'fxsave_to_fpregset' defined but not used and ../../intel/os/archdep.c:173:1: error: 'fpregset_to_fxsave' defined but not used 16:33:33 Not surprising given the refactoring and the lack of warning. 16:34:28 Those used to be called by getfpregs(), which was repalced to a single call to fpu.c driven code. 16:35:15 can be removed, I take it 16:36:07 tsoome: better dead code detection in newer gcc? 16:36:30 that one was with clang-15 16:36:57 but I haven't set the same gags on clang as we have for gcc 16:37:36 gcc would do it fine if we told it too. 16:38:01 -Wunused-function is nuanced with respect to debug builds historically. 16:38:12 yep. 16:38:14 At least it's not the double-edged sword of -Wunused-argument. 16:40:28 This commit made that function unused: https://github.com/illumos/illumos-gate/commit/ed093b41a93e8563e6e1e5dae0768dda2a7bcc27 17:45:08 what would be the recommended flags for ctfconvert/ctfmerge for building a third-party kernel module? 17:56:40 Nothing too special I think - I would not try and uniquify against genunix for example. 17:57:05 I'm just building fuse on omnios to see what it does 17:58:08 for tran_init_pkt() -- almost every invocation seems to pass NULL for arg1 (scsi_pkt) -- I'm assuming if actually non-NULL, the HBA should still just set all of the fields just as if it had called scsi_hba_pkt_alloc() and received a new scsi_pkt, right? 18:00:10 It does `ctfconvert -i -L VERSION fuse_vfsops.o` on every object then merges it all together at the end with 18:00:12 `ctfmerge -L VERSION -o fuse fuse_dev.o fuse_ini.o fuse_queue.o fuse_vnops.o fuse_vfsops.o` 18:00:28 but you can also do a convert on the final linked object nowadays 18:02:16 I would do exactly what our makefiles do, honestly. 18:03:57 Some do a converstion on the final linked object nowadays :D 18:04:05 with `CTF_MODE=link` 18:07:19 right, I meant the other flags etc. 18:08:22 we use the undocumented -X 18:08:41 which I guess deals with some struct cpu mess 18:09:45 Right, I think that's necessary (or at least helpful) if you are genunix, or are not uniquified against something that is genunix. 18:10:11 (it's probably unlikely that fuse cares about the machcpu though) 18:10:17 but all I have heard of fuse is bad things 18:10:45 one of these days, I'd still like to look at the work from long ago (I saved a branch) which used doors under the covers 18:10:51 for fuse 18:12:15 it's not really the implementation people have complained about in my presence 18:18:08 It was just the first out-of-gate kernel module I found. 18:20:12 Here's a probably better one https://github.com/omniosorg/illumos-kvm/blob/master/Makefile#L302-L313 18:31:05 andyf: i have added outside builds like fuse to original dilos-illumos build through external repo injections to be built with correct CTF 18:31:33 andyf: i did it for tun/tap, fuse, etc builds 18:32:16 andyf: because debug was painful if you have no types in genunix 21:00:13 hmm.. do any of the mdb API sym functions understand module`sym? 21:00:19 mdb_readsym() at least does not appear to 22:32:08 i should probably go ahead and throw up my changes for c11 anonymous struct and unions for ctf (I had done some bits for mdb, but moving it to ctf should allow it to also work for other things)... if I can find it :) 22:32:36 even if we don't use them in-gate, we can still leverage ctf for anything that does 22:40:41 on smartos, especially, that's a lot of stuff. 22:41:03 (the same is true of omnios, but omnios is smaller)