04:29:52 <mxshift> I've yet to meet an IB+RDMA fabric that worked for months at a time
04:30:06 <mxshift> And RoCE just makes it worse
12:15:14 <sjorge> anyone want to revieuw https://code.illumos.org/c/illumos-gate/+/2665 ? Send a mail to the list a while ago but looks like there waa bo response
12:15:15 <fenix> → CODE REVIEW 2665: 15271 document viona tunable to force copy of tx buffers (NEW) | https://www.illumos.org/issues/15271
17:14:52 <Smithx10> @mxshift  we are going to attempt to use DRBD with RDMA with roce lol
17:14:57 <Smithx10> may the force be with us :) 
17:47:19 <sommerfeld> https://www.illumos.org/issues/15435 looks like a loose end in libtopo 
17:47:20 <fenix> → BUG 15435: libtopo fails to build when fprintf is marked __PRINTFLIKE() (New)
17:48:35 <gitomat> [illumos-gate] 3816 "zfs allow" mis-displays filesystems with "allow -c" but not "allow -s" set -- Bill Sommerfeld <sommerfeld⊙ame>
17:48:53 <sommerfeld> https://www.illumos.org/issues/15434 is another long-lurking bug in apparently dead code.
17:48:54 <fenix> → BUG 15434: libima fails to build when sprintf is marked __PRINTFLIKE() (New)
19:06:08 <danmcd> Burn it all, sommerfeld!  :)
19:32:13 <sommerfeld> I hope some folks who actually understand that libtopo thing take a look.
19:36:25 <richlowe> jclulow, rmustacc: I think you're best placed to understand/know someone who understands, libtopo
19:44:02 <jbk> that was part of the work rob was doing to encode storage topologies (e.g. SAS, FC, ..) into fma
19:44:40 <jbk> i suspect it was more for completeness w/ processing an nvlist vs. being explicitly relied upon
19:46:12 <sommerfeld> yeah, though it wasn't actually complete.   IMHO would be better to just limit to the kernel nvlist dialect (no doubles)
19:47:37 <jbk> there's some standard storage library (like libHBAAPI.so or something like that) what I think comes into play.. I don't think there's anything there that'd be represented as a double (as that could be another potential source besides the kernel)
19:48:10 <jbk> i'd like to pick that up and try to finish it at some point since it'd be really nice for fma to understand topologies for fault analysis
19:49:08 <jbk> but too many other things keep getting in the way
19:50:02 <jbk> like i40e :)
19:53:58 <sommerfeld> there's not a lot of DATA_TYPE_DOUBLE references in illumos-gate
19:54:56 <rmustacc> I roughly understand libtopo, add me to something if you need a review sommerfeld?
19:55:25 <sommerfeld> .. or nvlist_add_double()
19:55:38 <richlowe> I have had to limit certain kernel things to avoid double on arm
19:55:40 <richlowe> for reasons
19:55:43 <richlowe> and perhaps temporarily
19:55:48 <sommerfeld> will do.
19:56:01 <richlowe> but less double's in the kernel would certainly make me happy
19:56:28 <sommerfeld> this is one point in userspace which is converting nvlist to xml and back again
19:57:09 <richlowe> I was just commenting on "limit the kernel dialect", I think I had to do that for kstats and and nvlists (both shoddily, right now).
19:57:10 <sommerfeld> if the nvlist has a double in it, current code will match up the double with a %s format, interpret the double as a pointer and likely fall over.
19:57:26 <richlowe> with gcc on arm, if you don't use the FPU you literally cannot spell 'double'
19:57:43 <richlowe> (there's nothing to store them other than in the FP registers)
19:58:13 <sommerfeld> (because of a missing comma resulting in string literal concatenation.   comedy of errors..)
19:58:24 <richlowe> oof
19:58:55 <sommerfeld> if the comma is inserted it still emits xml calling a float a uint64 so it's not going to round-trip back to nvlist as a double.
19:59:12 <sommerfeld> (all of the above assuming I'm reading the code correctly)
19:59:41 <tsoome> I was staring on that line trying to see the difference, took some time till I found the missing comma:D
20:00:21 <rmustacc> sommerfeld: Sounds like I should take a look at the write up on 15435 when I get some time?
20:00:56 <sommerfeld> there's not much to it.
20:01:16 <rmustacc> If this is in the digraph stuff, I have to build more of those soon.
20:01:31 <rmustacc> But just wanted to answer Rich's ping but can't really look right now.
20:01:57 <sommerfeld> rmustacc: though one of the things that concerns me is that it looks like most of the places that call nvlist_add_double() are in usr/src/lib/fm/topo ...
20:02:26 <richlowe> yeah, I wasn't so much trying to ping you both (sorry), but tell sommerfeld who might be around with the expertise
20:02:35 <richlowe> if not you two, then someone you hired I forgot about.
20:02:47 <sommerfeld> but presumably those nvlists don't get fed through the xml converter or else this would have been noticed
20:05:18 <sommerfeld> I'm not anywhere close to starting to push changes for review; I'm just filing bugs when I notice anomalies like this.
20:08:11 <sommerfeld> setting up so that when I do start sending stuff for review the weird special cases are isolated from the boring stuff that just does %d -> %zd or similar things.