10:17:26 toasterson - it might not be the way you want to go, but there is an illumos branch of cloud-init that we use in the omnios cloud images. Best way to be bug compatible with cloud-init, and it works well in AWS, Azure, DO, bhyve, ... 10:22:45 andyf: Are the dependencies still borked? It has this one unmaintained C dependency which I just could not get compiling on OI. I don't want to go the bug compatible route anyway. I am interested in Network config and getting something that can bootstrap the native config process. And metadata agent does that. I wanted to extend it for some time but since I can now drop in something decent network config it's enough to scratch my itch. It's 10:22:46 not a cloud image but it's enough automation so that I dn't have to run the installer manually. 10:26:44 I don't remember dependency problems - we've been shipping it in omnios for a few releases now 10:27:10 Yeah for some reason omnios doesn't have them 10:27:21 I can try again and see if I still hit it though 10:27:31 21.x was the last I tried 10:27:33 cloud-init was not too hard to port, and then we get all of the benefits and the different cloud provider support all for free 10:28:34 Well the porting part no, that dependency however is so deep in the code I'll have to rewrite how cloud-init finds network interfaces to get it out 10:30:05 I wonder why we don't see that on omnios. Interesting 10:30:44 IIRC that one dependency got a non version bump change last I checked and you have a package from before that. 10:31:09 I might need to pkgrecv your version from the repo. 10:31:25 and steal that 13:37:41 Well, in anycase. Splitting the user creating parts off into its own section worked. Now to do some testing 16:26:41 jclulow: richlowe Have the two of you any opposition against me refactoring image-builder into a library binary hibrid package? I need most of the functions in there for https://github.com/OpenFlowLabs/aurora-opencloud/blob/main/imgbuild/Cargo.toml and poaching/copying them seems a bit a waste. 16:54:29 [illumos-gate] 15290 lib: remove pragma ident -- Toomas Soome 16:54:35 ding:) 17:22:10 toasterson: I can think about how we might do it? I'm wary of creating a committed interface to be honest, especially without doing some of the refactoring I'd already like to do. 17:24:53 Well I as long as it's just us we wont need a commited interface. But I'll gladly follow along with the guidelines. I have a version for now but cant upgrade now as image-builder and my refactor have diverged so heavily I'll have to redo everything anyway. 17:25:44 Sould we start a IPD to flesh out what Patterns we want in the libraries? 17:27:05 Side note to channel: Somebody with permissions should delete https://github.com/illumos/illumos-gate/pull/87 as SPAM 17:32:18 The spam thing is on my list yeah 17:33:46 toasterson: I don't think we need an IPD. It would help if you could make a brief list of what of the existing behaviour you would want exposed as a library. Mail or gist would be fine 17:34:05 I'm also keen to replace the JSON with a KDL document for instance 17:34:33 jclulow: Then we can use my imgbuild work in parts 17:34:48 I focused on zone builds but it is KDL based 17:35:42 Do you have an example document I could look at 17:47:28 I just rebased https://code.illumos.org/c/illumos-gate/+/2619 past 15290 (would have RTI'ed this last week but getting set up to test it took longer than I wanted). 17:47:29 → CODE REVIEW 2619: 15356 closefrom(INT_MAX) misbehaves and closes all descriptors (NEW) | https://www.illumos.org/issues/15356 17:55:00 now, where did we stop with cw... 18:01:14 sommerfeld: Are you looking for review sill? 18:01:38 actually, looks like gerrit didn't invalidate the +1's after rebase. thought it would. 18:01:53 I don't think I need more eyes on it then. 18:02:00 No, if you just rebase and don't change anything (commit message included), it won't invalidate it. 18:02:40 the diff changed but the final file didn't and I guess the latter is what counts. 18:03:26 (both 15290 and the previously reviewed patchset of 15356 deleted the #ident from closefrom.c) 18:03:33 It looks like it didn't detect a change from patchset 2 to 3, which is I guess what it'd use. 18:03:43 Ah, interesting. Well, that's lucky I guess. 18:03:49 yup. 18:03:50 Kind of surprising. 18:06:08 must be comparing the git blob hash for each file instead of diffing the diffs. 18:17:54 jclulow: https://github.com/OpenFlowLabs/aurora-opencloud/blob/main/opczone/testdata/zones-base/build.kdl 18:18:11 Several infact the whole testdata folder contains samples 18:18:54 Huh, thats an old example.... 18:20:00 jclulow: https://github.com/OpenFlowLabs/aurora-opencloud/blob/main/opczone/testdata/image_base.kdl is more current 20:42:23 [illumos-gate] 15356 closefrom(INT_MAX) misbehaves and closes all descriptors -- Bill Sommerfeld 20:42:23 [illumos-gate] 15239 sharing pcieb HP/LBW interrupts with AER results in spurious ereports -- Keith M Wesolowski 21:41:13 [illumos-gate] 15269 pcieadm misrepresents PCIE_AER_CTL as PCIE_AER_RE_CMD -- Keith M Wesolowski