15:59:23 <andyf> I'm now getting the same failing gerrit behaviour as rzezeski reported recently
15:59:29 <andyf> error: remote unpack failed: error Missing tree 1d7a8b7ebbc1933fb023ae22621e4bdc34fd2654
16:00:56 <andyf> maybe something to do with a newer git version, I'll try the --no-thin 
16:01:22 <andyf> yes, that worked
16:12:24 <jbk> is git maybe defaulting to thin?
16:12:37 <jbk> w/ the newer version
16:12:58 <andyf> I can't see anything in the release notes. My client recently upgraded from 2.37.3 -> 2.37.5
17:50:33 <rmustacc> andyf: I found in the past a git fetch of the remote was fine.
17:50:47 <rmustacc> And cleared it up.
19:41:39 <jclulow> Yeah I frequently do "git fetch --all --prune" before I do anything else
19:42:54 <jclulow> FWIW we run "git gc" against the repository each day
19:43:04 <jclulow> To keep it from growing forever
19:43:08 <jclulow> Maybe that's having an impact
19:50:54 <sommerfeld> any cases where we've done history-changing operations (like git commit --amend or rebase) on published branchese?
19:51:21 <sommerfeld> (would be interesting to know what the missing tree actually was - it might be present in the client repository)
19:51:32 <richlowe> not for years.
19:51:55 <richlowe> usually when we've missed a tree like this it's because there's disagreement about where the master branch points
19:55:16 <sommerfeld> git ls-tree 1d7a8b7ebbc1933fb023ae22621e4bdc34fd2654 in my checkout shows some version of what looks to be ./usr/src/uts/intel/io/vmm
19:59:02 <sommerfeld> but that's not the most recent version of that tree
20:02:03 <sommerfeld> but it's the version of usr/src/uts/intel/io/vmm in f2357d972e19ef505ad57ff2f0ee340fa2214015 ("15236 viona ring page holds should heed pause/resume")
20:03:15 <sommerfeld> (you can see this with  git ls-tree f2357d972e19ef505ad57ff2f0ee340fa2214015:usr/src/uts/intel/io
20:03:15 <sommerfeld>  )
20:05:31 <sommerfeld> that's a pretty recent commit (December 2022 author date..)
20:06:15 <sommerfeld> committed January 4th 2023
20:09:25 <sommerfeld> tree was was most recent version of that subtree until 62ac5a8a4bcebad1d1c5639636a038087707a5e0 ("15251 panic in vlapic_get_ccr after live migration / 15312 bhyve has overzealous vlapic ID check") committed on January 10th 2023.
20:10:21 * jclulow runs "git fsck" on the repository
20:11:20 <sommerfeld> (in case you're wondering how I found the commits:  git log --oneline -- usr/src/uts/intel/io/vmm | while read commit rest
20:11:21 <sommerfeld> do
20:11:21 <sommerfeld> echo $commit; git ls-tree ${commit}:usr/src/uts/intel/io | (grep 1d7a8b7ebbc; exit 0)
20:11:21 <sommerfeld> done
20:11:50 <sommerfeld> (the (grep ... ; exit 0) is to avoid having my shell warn me about failing greps)
20:12:48 <jclulow> the old one-two, grep || true
20:13:24 <sommerfeld> lots of ways to spell that.
20:13:43 <jclulow> So there are a handful of dangling commits
20:15:14 <sommerfeld> gc failure dropping something that was actually referenced?   eek.
20:16:21 <jclulow> I don't think so
20:16:42 <jclulow> I think it's an artefact of commits submitted for review being actual commits under magic refs
20:17:22 <richlowe> we've definitely definitely seen this before transiently
20:18:03 <jclulow> (that is: I believe the five dangling commits are changes that are not integrated, and is presumably an artefact of an incomplete submission)
20:18:18 <jclulow> The other issue I dunno about
20:18:33 <jclulow> But I expect I have never seen it because I fetch aggressively
20:19:13 <jclulow> It could also be because I'm a slacker that doesn't do that much work
20:19:15 <jclulow> :D
20:19:41 <richlowe> same, on both counts
20:19:47 <richlowe> my git stuff keeps itself current for me
20:20:21 <richlowe> I think the time I saw something like this I had a 'master' that gerrit didn't, or vice versa.
20:20:54 <sommerfeld> i'm curious as to where "error: remote unpack failed: error Missing tree 1d7a8b7ebbc1933fb023ae22621e4bdc34fd2654" came from.   Something logged by gerrit or by the git client doing the push?
20:21:11 <sommerfeld> (or, well, git-as-run-by-gerrit)
20:26:44 <gitomat> [illumos-gate] 15345 Fix function prototype in in.routed/if.c -- Marco van Wieringen <marco.van.wieringen⊙pen>
20:42:39 <andyf> Thanks, I'll try doing a pull from the gerrit upstream, I don't do that routinely. This was a new commit in a branch just taken from master, so I was surprised that it didn't work
20:47:35 <sommerfeld> I think a pull from gerrit gives the client a better idea of what gerrit does and doesn't have already.. 
20:48:59 <sommerfeld> (pull before push, that is..)
20:54:49 <jclulow> Midvale Repository for the Gifted
20:55:48 <jbk> :)
20:56:06 <richlowe> jclulow: hey, but while you're in there, great time for that upgrade... :)
20:56:28 <jclulow> oh goodness my fridge is running brb
20:56:32 <jbk> heh.. always fun when you're doing a test, pretty sure it should be harmless and the network link to that location dies seconds after you run your command :)
21:05:11 <richlowe> did everything get untangled now then?
21:08:41 <jbk> jclulow: i'd imagine it can't get too far
21:12:10 <sommerfeld> most gifted thing I've seen Gerrit do is attempt to create reviews for every single existing commit in the repo when it was confused about where I was pushing to.
21:12:52 <jclulow> I think it might have some safeties against users making that error now
21:13:07 <jclulow> (touch wood)
21:13:57 <richlowe> I have twice now almost pushed a large feature branch by mistake, because habit of which workspace I'm in
21:14:10 <richlowe> luckily, I also habitually -nv
21:45:25 <tomww> :)
22:06:11 <sommerfeld> jclulow: this happened >10 years ago and my typo might well have been one of the incidents motivating the creation of the safeties.
22:33:32 <richlowe> did anyone want more time to look at #15260 or #15361? (fenix?)
22:33:33 <fenix> BUG 15260: ld crashes if group members are stripped by -s (In Progress)
22:33:34 <fenix> ↳ https://www.illumos.org/issues/15260 | https://code.illumos.org/c/illumos-gate/+/2601
22:33:43 <richlowe> and the other, bot...
23:04:36 <andyf> illumos 15361 (fenix) ?
23:04:37 <fenix> BUG 15361: ld doesn't fill out PT_DYNAMIC sufficiently for binutils 2.40 (In Progress)
23:04:37 <fenix> ↳ https://www.illumos.org/issues/15361 | https://code.illumos.org/c/illumos-gate/+/2620