10:55:16 <andyf> danmcd - that's an interesting side-effect of the isatty() change that feels like a new bug
10:55:45 <andyf> a successful call to printf() should not set errno
11:08:18 <andyf> Filed issue 15294 (fenix)
11:08:19 <fenix> BUG 15294: Successful *printf() calls should not set errno (In Progress)
11:08:19 <fenix> ↳ https://www.illumos.org/issues/15294
16:04:26 <tsoome_> hm. ::stack does not present proper number of function parameters:(
16:18:27 <jbk> tsoome_: it should use ctf, but i think it's still capped at 6 if a function uses more
16:27:31 <danmcd> andyf: If your bug is correct/actual/etc., then 15291 should be marked as a subset of yours.
16:27:52 <danmcd> I couldn't reproduce it with a toy, FWIW.  I suspect there needs to be long buffering or something.
16:28:28 <danmcd> And it might be strerror for all I know?
16:31:05 <tsoome_> jbk ah, that explains, this one had 8
16:34:12 <jbk> yeah, it's actually a reason why I try to avoid writing functions with more than 6 arguments... yeah you can fish out the arguments from the stack, but it's kinda annoying
17:30:12 <andyf> danmcd - I've added a test as part of https://code.illumos.org/c/illumos-gate/+/2582
17:30:13 <fenix> → CODE REVIEW 2582: 15294 Successful *printf() calls should not set errno (NEW) | https://www.illumos.org/issues/15294
17:31:01 <andyf> The ZFS tests still needed fixing, they shouldn't assume errno is unchanged over other function calls
17:40:22 <andyf> If you ran your toy and piped it through cat, it would probably have reproduced. The output needs to be not-a-TTY
17:48:33 <gitomat> [illumos-gate] 15132 libsmb SMF initialization problem messages incorrect -- Andy Fiddaman <illumos⊙fn>
19:22:11 <richlowe> andyf: I'm just catching up, but did you check for other people who isatty and don't preserve errno?
20:20:54 <danmcd> Sonofabitch @andyf, you're right.
20:21:49 <danmcd> When I'm back (firefighting has kept me from proper time off, so I'm extending what I'd planned into most/all of next week) I can test this in lieu of fenix illumos 15291
20:21:50 <fenix> BUG 15291: zfs-tests errno flaws exposed by 15220 (New)
20:21:50 <fenix> ↳ https://www.illumos.org/issues/15291 | https://code.illumos.org/c/illumos-gate/+/2579
20:22:10 <danmcd> (right now that only exists in the 20221229 branch of illumos-joyent).
20:22:14 <danmcd> Okay back to being off...
20:47:55 <andyf> richlowe - rmustacc did a survey of isatty() as part of issue 15220 (fenix) - we were the odd one out in terms of always preserving errno, and now we're aligned with what people expect (POSIX technically allows either).
20:47:57 <fenix> BUG 15220: isatty should return reasonable errnos (Closed)
20:47:57 <fenix> ↳ https://www.illumos.org/issues/15220 | https://code.illumos.org/c/illumos-gate/+/2540
20:48:04 <andyf> If that's what you're asking
20:48:31 <richlowe> No, I'm asking whether there's other code like *rintf that maybe calls isatty inside itself, but doesn't expect errno
20:49:12 <andyf> Ah, got it. I checked usr/src/lib/ and fixed up a couple of other callers in there as part of the same change.
20:49:20 <andyf> I should probably add a second bug ID for that bit
20:49:43 <andyf> I looked briefly through usr/src/cmd too, but not exhaustively.
22:37:11 <gitomat> [illumos-gate] 15295 SMB services should check IPC caller privileges -- Gordon Ross <gwr⊙rc>