01:05:40 <danmcd> @alanc yes.  (Disappearing now to pick up daughter...)
08:38:05 <gitomat> [illumos-gate] 15199 libdladm: unused label -- Toomas Soome <tsoome⊙mc>
08:55:03 <gitomat> [illumos-gate] 15200 libdladm: error: '&&' within '||' -- Toomas Soome <tsoome⊙mc>
10:12:55 <sjorge> so propolis is rust right? does that mean all the userspace emulation has the same
10:13:01 <sjorge> protection rust offers?
10:13:11 <sjorge> or is that mostly unsafe code so it doesnt?
10:13:57 <sjorge> OK that was a dumb question, i can just look at the code,
10:15:45 <sjorge> ok thats a lot of code, will have to look when i am not on my
10:15:47 <sjorge> phone
14:48:51 <nbjoerg> sjorge: isn't the interesting code in bhyve the actual device emulation?
14:49:01 <nbjoerg> sjorge: so does this actually do anything?
16:32:33 <danmcd> So I discovered a teeny-tiny test bug.  If your login (say on a serial line) sets COLUMNS in the environment, the sed test suite will fail in one-out-of-130 tests, causing the suite to report failure.
16:32:56 <danmcd> I'm wondering if it's an actual test bug, or a "you should know better" situation.
16:40:15 <pmooney> sjorge: yeah, propolis is in rust, and mostly safe rust at that
16:40:59 <pmooney> nbjoerg: most of the device emulation is done in userspace
17:44:19 <gitomat> [illumos-gate] 15211 smbtorture failures in smb2.delete-on-close-perms.READONLY -- Gordon Ross <gwr⊙rc>
17:55:57 <rmustacc> danmcd: In general I feel we should fix the tests to be as reliable as we can.
17:56:08 <rmustacc> So we should look at how to fix that.
17:56:51 <gitomat> [illumos-gate] 15258 libsmb: tautological-pointer-compare -- Toomas Soome <tsoome⊙mc>
18:12:02 <gitomat> [illumos-gate] 15253 14993 broke test-runner -l option -- Toomas Soome <tsoome⊙mc>
18:17:00 <danmcd> rmustacc: Thank you for cashing the reality check.  
18:27:45 <danmcd> jinni illumos 15266
18:27:53 <danmcd> jinni illumos#15266
18:28:08 <danmcd> https://www.illumos.org/issues/15266
18:28:09 <fenix> → BUG 15266: sed test is sensitive to COLUMNS in the environment (New)
18:36:33 <danmcd> https://code.illumos.org/c/illumos-gate/+/2564
18:36:34 <fenix> → CODE REVIEW 2564: 15266 sed test is sensitive to COLUMNS in the environment (NEW) | https://www.illumos.org/issues/15266
18:39:16 <andyf> I never knew sed looked at COLUMNS.. there are some other conditions in there
18:39:54 <andyf> we should probably just make the test always pipe the output of sed through cat - that would make it consistent regardless of COLUMNS or what TIOCGWINSZ returns
18:53:17 <danmcd> andyf: I tried changing the one failed test...
18:53:21 <danmcd> -       $SED -n l $lines3
18:53:21 <danmcd> +       cat $lines3 | $SED -n l | cat
18:53:37 <danmcd> and it still fails with COLUMNS set.
18:54:04 <andyf> Ah yes, the test is '        if (outfile != stdout)'
18:54:09 <andyf> fair enough
18:54:52 <danmcd> The "l" function must always read COLUMNS and honor it.
18:55:10 <danmcd> Did update the comment to yours, however.
18:55:56 <andyf> Thanks. I'm just wary of putting bug tracker links in source generally.
19:02:03 <danmcd> Ack.
19:10:14 <danmcd> If anyone from FreeBSD-land happens to be here, please ping me as I'm curious if my above bug affects FreeBSD or not?
19:16:37 <nbjoerg> danmcd: sed has some logic in it that is tty specific
19:16:43 <danmcd> I know.
19:16:52 <nbjoerg> and if it can't read the window size, it falls back to env
19:17:00 <nbjoerg> so that seems sensible
19:17:03 <danmcd> Which in the middle of a test script it can't.
19:17:56 <nbjoerg> test should sanitize the environment
19:21:11 <danmcd> nbjoerg: See my Gerrit link above.
19:22:02 <danmcd> Oh... NVM, you SAW it already.
19:28:06 <nbjoerg> right, change looks correct
21:37:58 <danmcd> nbjoerg: You can add a +1 on the gerrit if you deem it appropriate.